From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id A2B67385481A for ; Wed, 17 Mar 2021 15:53:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org A2B67385481A Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 12HFqoOu024797 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 17 Mar 2021 11:52:54 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 12HFqoOu024797 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id F2BB21E789; Wed, 17 Mar 2021 11:52:49 -0400 (EDT) Subject: Re: sim: replacing ChangeLog files with online git logs To: Eli Zaretskii , Luis Machado Cc: gdb@sourceware.org References: <83ft0zjys1.fsf@gnu.org> <83lfarhwjq.fsf@gnu.org> <83eegjhuuq.fsf@gnu.org> <8335wyj461.fsf@gnu.org> <83tup9disi.fsf@gnu.org> <2012fb21-38f2-3d1c-62c8-52d94d19e243@linaro.org> <83pmzxdegd.fsf@gnu.org> <83o8fhddg3.fsf@gnu.org> <18f4f0e2-0a35-a6c5-1886-943f81f817fd@linaro.org> <83mtv1dbzr.fsf@gnu.org> From: Simon Marchi Message-ID: Date: Wed, 17 Mar 2021 11:52:49 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <83mtv1dbzr.fsf@gnu.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Wed, 17 Mar 2021 15:52:50 +0000 X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Mar 2021 15:53:07 -0000 We're getting into this again, I know you've said the horse has been beaten to death about ChangeLogs, but it keeps coming up because it's a real daily pain for many people. On 2021-03-17 11:40 a.m., Eli Zaretskii via Gdb wrote: > The list of files touched by a changeset can be easily generated, but > the functions/macros/classes not so easily, and not necessarily > accurately enough, even if we will use the more elaborate script that > is used by glibc. So some information loss will be present. > > OTOH, the ChangeLog-format Git log messages don't require one to have > the ChangeLog file, they just require to use the same format when > describing the changeset. It's not the ChangeLog file per-se that's annoying, it's writing the entry. It's tedious and contains mostly uninteresting information. So putting the ChangeLog entry in the git log instead of a file doesn't change anything. In the GDB project, we write what I believe are excellent git commit messages that go in depth describing the observed problem and the solution provided by the patch. That provides valuable information for anyone wanting to understand why the code is the way it is. A list of modified symbols doesn't help. So I am completely fine if the "list of modified symbols" part of the information is lost. > If you use Emacs to make the changes > themselves and commit the changes into Git, you just need to use the > Emacs commands to format the Git log messages, those commands will > produce the same information as the manual ChangeLog files > automatically. I don't really understand how that helps, you still have to spell out the symbols. But please don't assume everyone uses Emacs. Making a decision based on "Emacs makes it easy" and ignoring the rest of users wouldn't be fair. > If that is not an option that this community wants to adopt, then > gitlog-to-changelog is probably not the adequate solution, and we > should try using vcs-to-changelog.py (also in Gnulib). I tried vcs-to-changelog, it gave horrible/useless results with our codebase. This is not an option. Simon