From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cp165172.hpdns.net (cp165172.hpdns.net [91.238.165.172]) by sourceware.org (Postfix) with ESMTPS id AE8823957055 for ; Thu, 11 Jun 2020 21:21:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org AE8823957055 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=dyxyl.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=qqxnjvamvxwx@dyxyl.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=dyxyl.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=VtrijcmFGeLI8S3ju2e+1ljq7sq4mgyg2MXQDZh9fSw=; b=U5sHoOIOaiCIeGQxAjdqPhvw/c HBkXg77Eq8/1hYOygc8GaU1ItH1CaWc1X4XFr4L+qeGZtzErr15DbjTxS5IeneRob62dp0UVC4eD3 Sv1K3c6UZw6YHC51MeXv8lO/R9aPFjrK7Qw4XPzall7efTqnHW6Wo+V4cE3FmCfjoBp8=; Received: from cpc92314-cmbg19-2-0-cust794.5-4.cable.virginm.net ([82.11.187.27]:49668 helo=localhost.localdomain) by cp165172.hpdns.net with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1jjUdW-0067SV-L4; Thu, 11 Jun 2020 22:21:22 +0100 Received: by localhost.localdomain (Postfix, from userid 597) id 0B866600FA; Thu, 11 Jun 2020 22:21:22 +0100 (BST) From: Martin Simmons To: Shahab Vahedi Cc: gdb@sourceware.org,shahab@synopsys.com Subject: Re: Why enforcing sw_breakpoint_from_kind() implementation in GDBserver targets In-Reply-To: <20200610174702.GA3486@gmail.com> (message from Shahab Vahedi via Gdb on Wed, 10 Jun 2020 19:47:02 +0200) References: <20200610174702.GA3486@gmail.com> Date: Thu, 11 Jun 2020 22:21:21 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-cPanel-MailScanner-Information: Please contact the ISP for more information X-cPanel-MailScanner-ID: 1jjUdW-0067SV-L4 X-cPanel-MailScanner: Found to be clean X-cPanel-MailScanner-SpamCheck: X-cPanel-MailScanner-From: qqxnjvamvxwx@dyxyl.com X-Spam-Status: No, score=0.7 required=5.0 tests=BAYES_20, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, HK_RANDOM_ENVFROM, HK_RANDOM_FROM, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - cp165172.hpdns.net X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - dyxyl.com X-Get-Message-Sender-Via: cp165172.hpdns.net: authenticated_id: dyxyl/from_h X-Authenticated-Sender: cp165172.hpdns.net: qqxnjvamvxwx@dyxyl.com X-Source: X-Source-Args: X-Source-Dir: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Jun 2020 21:21:36 -0000 >>>>> On Wed, 10 Jun 2020 19:47:02 +0200, Shahab Vahedi via Gdb said: > > Last but not least, one nitpick: Even though I have added the > implementation of "sw_breakpoint_from_kind", I have never done so for > "breakpoint_kind_from_pc" or "breakpoint_kind_from_current_state". > These last two are supposed to provide the "kind" that will be the > input parameter for "sw_breakpoint_from_kind". Therefore, even if the > new piece of "sw_breakpoint_from_kind" would be executed, that would be > problematic. I'm not sure what can be done about this but I think _if_ > "sw_breakpoint_from_kind" should be mandatory, so are > "breakpoint_kind_from_pc" and "breakpoint_kind_from_current_state". "breakpoint_kind_from_pc" and "breakpoint_kind_from_current_state" have default implementations in gdbserver/target.cc so there is no need to make them mandatory. __Martin