From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8721 invoked by alias); 9 Jul 2003 14:10:18 -0000 Mailing-List: contact gdb-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sources.redhat.com Received: (qmail 8712 invoked from network); 9 Jul 2003 14:10:17 -0000 Received: from unknown (HELO Cantor.suse.de) (213.95.15.193) by sources.redhat.com with SMTP; 9 Jul 2003 14:10:17 -0000 Received: from Hermes.suse.de (Hermes.suse.de [213.95.15.136]) by Cantor.suse.de (Postfix) with ESMTP id 8364E14A3D for ; Wed, 9 Jul 2003 16:09:21 +0200 (MEST) To: gdb@sources.redhat.com Subject: Re: A matter of taste? References: <20030709135543.GO12368@cygbert.vinschen.de> From: Andreas Schwab X-Yow: Could I have a drug overdose? Date: Wed, 09 Jul 2003 14:10:00 -0000 In-Reply-To: <20030709135543.GO12368@cygbert.vinschen.de> (Corinna Vinschen's message of "Wed, 9 Jul 2003 15:55:43 +0200") Message-ID: User-Agent: Gnus/5.1002 (Gnus v5.10.2) Emacs/21.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-SW-Source: 2003-07/txt/msg00093.txt.bz2 Corinna Vinschen writes: |> Hi, |> |> I'm currently substituting a bunch of calls to REGISTER_RAW_SIZE. |> Since REGISTER_RAW_SIZE should be removed entirely, I was wondering |> how to do it most nicely. |> |> What I don't quite get is the implementation of function register_size |> in regcache.c. It retrieves the size of the regsiter from the |> regcache and then checks twice(!) if that size equals REGISTER_RAW_SIZE. The second check probabably should have been against REGISTER_VIRTUAL_SIZE. |> If I understand that correctly, a multi-arched target which got rid of |> REGISTER_RAW_SIZE can't use register_size () since the REGISTER_RAW_SIZE |> calls in register_size will raise an internal_error in |> gdbarch_deprecated_register_raw_size(). If you don't define REGISTER_RAW_SIZE then it is defined to generic_register_size, which uses TYPE_LENGTH. |> What is that good for? And what's the substitute for a target with |> no REGISTER_RAW_SIZE implementation? Just use register_size. Works fine on m68k. Andreas. -- Andreas Schwab, SuSE Labs, schwab@suse.de SuSE Linux AG, Deutschherrnstr. 15-19, D-90429 Nürnberg Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."