From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28934 invoked by alias); 23 Apr 2012 15:49:27 -0000 Received: (qmail 28827 invoked by uid 22791); 23 Apr 2012 15:49:25 -0000 X-SWARE-Spam-Status: No, hits=-6.3 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 23 Apr 2012 15:49:12 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q3NFnC4Q010046 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 23 Apr 2012 11:49:12 -0400 Received: from psique ([10.3.112.7]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q3NFn5Tm031503; Mon, 23 Apr 2012 11:49:08 -0400 From: Sergio Durigan Junior To: Tom Tromey Cc: Jan Kratochvil , gdb@sourceware.org Subject: Re: Switch -Wunused-variable on? References: <20120422082240.GA21311@host2.jankratochvil.net> <87sjfufrlr.fsf@fleche.redhat.com> X-URL: http://www.redhat.com Date: Mon, 23 Apr 2012 15:49:00 -0000 In-Reply-To: <87sjfufrlr.fsf@fleche.redhat.com> (Tom Tromey's message of "Mon, 23 Apr 2012 08:30:24 -0600") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-IsSubscribed: yes Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org X-SW-Source: 2012-04/txt/msg00183.txt.bz2 On Monday, April 23 2012, Tom Tromey wrote: > I'd say that the best approach would be to make the declarations > conditional in the same way that the uses are. > > If there are a lot of problem cases with this approach, or if it makes > the code too ugly, then maybe it would be better just not to use this > flag. Ok, that makes sense to me. Since there are tons of places with unused variables in the code, I will take some time to look and convert the proper places to use this solution. Thanks! -- Sergio