From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15333 invoked by alias); 22 Apr 2012 08:06:39 -0000 Received: (qmail 15324 invoked by uid 22791); 22 Apr 2012 08:06:37 -0000 X-SWARE-Spam-Status: No, hits=-6.3 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 22 Apr 2012 08:06:20 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q3M86KoJ000859 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Sun, 22 Apr 2012 04:06:20 -0400 Received: from psique ([10.3.112.7]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q3M7EjYS021875 for ; Sun, 22 Apr 2012 03:14:47 -0400 From: Sergio Durigan Junior To: gdb@sourceware.org Subject: Switch -Wunused-variable on? X-URL: http://www.redhat.com Date: Sun, 22 Apr 2012 08:06:00 -0000 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-IsSubscribed: yes Mailing-List: contact gdb-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sourceware.org X-SW-Source: 2012-04/txt/msg00171.txt.bz2 Hello, While doing something else, I decided to enable the -Wunused-variable option and... bummer. So I decided to prepare a patch to fix this, because there are *many* places with unused variables. However, before continuing to prepare this patch, I would like what you think about enabling -Wunused-variable by default in the building. I am not sure I can foresee something wrong with it, but maybe others have some different opinions. Thanks, -- Sergio P.S.: I couldn't find any real discussion about this on the list archives, but please excuse me if this has been already discussed.