From: Tom Tromey <tromey@redhat.com>
To: dje@google.com (Doug Evans)
Cc: gdb@sourceware.org
Subject: Re: find_and_open_source bug?
Date: Tue, 01 Nov 2011 19:11:00 -0000 [thread overview]
Message-ID: <m3pqhb1wvu.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20111029204637.C44D9246191@ruffy.mtv.corp.google.com> (Doug Evans's message of "Sat, 29 Oct 2011 13:46:37 -0700 (PDT)")
>>>>> "Doug" == Doug Evans <dje@google.com> writes:
Doug> If find_and_open_source opens the file via rewrite_source_path,
Doug> should xfullname get called?
Doug> Grep for XXX below.
Doug> Seems so, otherwise the caller can't really assume what's
Doug> stored in *fullname is a "fullpath" (as defined by xfullpath).
Doug> [Maybe rewritten source paths shouldn't get passed through xfullpath
Doug> but then why does the rest of the function do that?]
Doug> [I'm trying to understand what invariants callers of find_and_open_source
Doug> can expect.]
Probably nobody has ever tried to do something weird here.
I think it would be safe for you to pick an approach that preserves
whatever sensible user scenarios there are. E.g., require that path
substitutions map full paths to full paths or something like that.
Tom
prev parent reply other threads:[~2011-11-01 19:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-29 20:47 Doug Evans
2011-11-01 19:11 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3pqhb1wvu.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=dje@google.com \
--cc=gdb@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).