From: Tom Tromey <tromey@redhat.com>
To: Joost van der Sluis <joost@cnoc.nl>
Cc: gdb@sourceware.org, Pierre Free Pascal <pierre@freepascal.org>
Subject: Re: Patch for allowing calling pascal-methods (fpc)
Date: Wed, 19 Oct 2011 20:06:00 -0000 [thread overview]
Message-ID: <m3sjmovjex.fsf@fleche.redhat.com> (raw)
In-Reply-To: <1318405583.25241.17.camel@feddie.cnoc.lan> (Joost van der Sluis's message of "Wed, 12 Oct 2011 09:46:23 +0200")
>>>>> "Joost" == Joost van der Sluis <joost@cnoc.nl> writes:
Tom> I am not sure that applying this patch is ok. It is generic code, so
Tom> this change may negatively affect other languages -- it is hard to be
Tom> sure without replicating your analysis.
Joost> Thing is that this function is only used by the Pascal parser, and
Joost> within the ada-lang.c file. So it could be useful if someone with more
Joost> ada-knowledge could have a look at it. (I did have gnat installed when
Joost> doing the test-runs)
No, there are calls to it from eval.c, e.g. for the STRUCTOP_STRUCT
case, which is emitted by the C parser.
If you can prove it does not negatively affect other languages then that
would be ok.
Joost> I could also create a wrapper-function in p-lang.c, that calls
Joost> lookup_struct_elt_type and then does the additional search within the
Joost> FN-fields. But that's very difficult (impossible?), because of the
Joost> inheritance: A field has to be searched first within it's own class, and
Joost> only if it's not found in it's base-classes.
I think a new function alongside lookup_struct_elt_type in gdbtypes.c
would be fine.
Tom
prev parent reply other threads:[~2011-10-19 20:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-20 19:54 Joost van der Sluis
2011-10-05 18:14 ` Tom Tromey
2011-10-12 7:46 ` Joost van der Sluis
2011-10-19 20:06 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3sjmovjex.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb@sourceware.org \
--cc=joost@cnoc.nl \
--cc=pierre@freepascal.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).