public inbox for gdb@sourceware.org
 help / color / mirror / Atom feed
From: Klaus Zeitler <kzeitler@lucent.com>
To: Andreas Schwab <schwab@suse.de>
Cc: gdb@sources.redhat.com, gdb-patches@sources.redhat.com
Subject: Re: gdb output problems when run in shell (bash or ksh)
Date: Tue, 02 Aug 2005 13:57:00 -0000	[thread overview]
Message-ID: <q5gack0wiez.fsf@lucent.com> (raw)
In-Reply-To: <jeoe8g36c6.fsf@sykes.suse.de> (Andreas Schwab's message of "Tue, 02 Aug 2005 13:51:05 +0200")

>>>>> "Andreas" == Andreas Schwab <schwab@suse.de> writes:
    Andreas> 
    Andreas> Does this patch help?
    Andreas> 
    Andreas> 	* sol-thread.c (sol_thread_wait): Call target_terminal_ours before
    Andreas> 	printing output.
    Andreas> 
    Andreas> --- gdb/sol-thread.c.~1.50.~	2005-06-27 10:03:40.000000000 +0200
    Andreas> +++ gdb/sol-thread.c	2005-08-02 13:46:35.000000000 +0200
    Andreas> @@ -463,6 +463,7 @@ sol_thread_wait (ptid_t ptid, struct tar
    Andreas>  	  && !ptid_equal (rtnval, save_ptid)
    Andreas>  	  && !in_thread_list (rtnval))
    Andreas>  	{
    Andreas> +	  target_terminal_ours ();
    Andreas>  	  printf_filtered ("[New %s]\n", target_pid_to_str (rtnval));
    Andreas>  	  add_thread (rtnval);
    Andreas>  	}

What a quick reply. Your patch didn't help, but if gave me an idea where to
look. I searched for other calls of 'printf_filtered ("[New %s]\n"' (11
matches) and it worked, when I added the call to target_terminal_ours in
module procfs.c to the first occurrence of 'printf_filtered ("[New %s]\n"':

		    if (!in_thread_list (temp_ptid))
		      {
			  target_terminal_ours ();
			printf_filtered ("[1:New %s]\n",
					 target_pid_to_str (temp_ptid));
			add_thread (temp_ptid);
		      }

A closer look revealed that the problem is caused by prompt_for_continue in
fputs_maybe_filtered. It seems as if gdb counts the 'New thread' messages
and prompts for continuation according to page height.
When I set page height in gdb to 0, the problem also disappears.

Thanks

Klaus


-- 
 ------------------------------------------
|  Klaus Zeitler      Lucent Technologies  |
|  Email:             kzeitler@lucent.com  |
 ------------------------------------------
---
Real programmers don't comment their code.  It was
hard to write, it should be hard to understand.

      reply	other threads:[~2005-08-02 13:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-08-02  9:04 Klaus Zeitler
2005-08-02 11:51 ` Andreas Schwab
2005-08-02 13:57   ` Klaus Zeitler [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=q5gack0wiez.fsf@lucent.com \
    --to=kzeitler@lucent.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=gdb@sources.redhat.com \
    --cc=schwab@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).