From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20267 invoked by alias); 25 Apr 2003 04:35:31 -0000 Mailing-List: contact gdb-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-owner@sources.redhat.com Received: (qmail 20260 invoked from network); 25 Apr 2003 04:35:30 -0000 Received: from unknown (HELO jackfruit.Stanford.EDU) (171.64.38.136) by sources.redhat.com with SMTP; 25 Apr 2003 04:35:30 -0000 Received: (from carlton@localhost) by jackfruit.Stanford.EDU (8.11.6/8.11.6) id h3P4ZOl10171; Thu, 24 Apr 2003 21:35:24 -0700 X-Authentication-Warning: jackfruit.Stanford.EDU: carlton set sender to carlton@math.stanford.edu using -f To: Andrew Cagney Cc: gdb , Elena Zannoni , Jim Blandy Subject: Re: [rfc] struct dictionary References: <3EA89AB3.6050403@redhat.com> From: David Carlton Date: Fri, 25 Apr 2003 04:35:00 -0000 In-Reply-To: <3EA89AB3.6050403@redhat.com> Message-ID: User-Agent: Gnus/5.0808 (Gnus v5.8.8) XEmacs/21.4 (Common Lisp) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2003-04/txt/msg00311.txt.bz2 On Thu, 24 Apr 2003 22:17:23 -0400, Andrew Cagney said: >> Blocks currently store symbols in one of three different ways: >> using a hash table, using an unsorted list, or using a sorted list. >> Most blocks are built by buildsym.c, which use only the former two >> mechanisms. Sorted list blocks are only being produced by >> mdebugread.c. And, to make matters worse, jv-lang.c produces one >> unsorted list block for which the predicate BLOCK_SHOULD_SORT >> matches; the chain of events by which GDB actually treats that >> block correctly is very tenuous. > Um, didn't BLOCK_SHOULD_SORT get deleted? No. I tried in last fall, but Jim didn't like it because it probably would have made performance for mdebugread be awful. Daniel recently proposed hashing sorted blocks on the fly, but he withdrew that patch quickly when he found a way to work around whatever problem caused him to be particularly annoyed with sorted blocks. Basically, either somebody needs to buildsym-ify mdebugread.c or else symbol lookup has to be made a bit more abstract. These would actually both be good ideas for reasons other than getting rid of BLOCK_SHOULD_SORT, so it's certainly not an either-or choice. David Carlton carlton@math.stanford.edu