From: "Jan Beulich" <JBeulich@novell.com>
To: <drow@false.org>,<ian@wasabisystems.com>
Cc: <binutils@sources.redhat.com>,<gdb@sources.redhat.com>
Subject: [PATCH] Re: gas: should duplicate .macro directives be allowed?
Date: Tue, 08 Mar 2005 09:43:00 -0000 [thread overview]
Message-ID: <s22d7385.021@emea1-mh.id2.novell.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 2682 bytes --]
>>> Daniel Jacobowitz <drow@false.org> 07.03.05 17:19:17 >>>
>On Mon, Mar 07, 2005 at 11:15:02AM -0500, Ian Lance Taylor wrote:
>> "Jan Beulich" <JBeulich@novell.com> writes:
>>
>> > Yes, the change was deliberate, and I don't think it'd be wise to
revert
>> > it (it's simply dangerous considering that you might have these
>> > collisions resulting from two include files, each of which relies
on
>> > their definition of the respective macro). Instead, if you need
to
>> > override a previous macro definition (and know what you're doing),
you
>> > can use easily use .purgem before the new definition (really, I'd
rather
>> > recommend not to to catch the collision). Jan
>>
>> That seems more or less reasonable to me, but Daniel is correct
that
>> this change must be mentioned in NEWS. It should be documented
>> somewhere in as.texinfo as well, if it is not already.
>
>While I'm wishing, it would be nice if the documentation mentioned
>.purgem somewhere from .macro. I spent a while trying to figure out
if
>there was a right way to do this from the manual, and did not come
>across .purgem until Jan mentioned it.
gas/
2004-03-08 Jan Beulich <jbeulich@novell.com>
* doc/as.texinfo: Add sentence to indicate redefining a macro is
an
error, and point to .purgem documentation if someone really
needs
re-definitions.
* NEWS: Mention macro redefinition is now an error.
---
/home/jbeulich/src/binutils/mainline/2005-03-08/gas/NEWS 2005-02-28
08:27:12.000000000 +0100
+++ 2005-03-08/gas/NEWS 2005-03-08 10:14:27.334292936 +0100
@@ -1,5 +1,7 @@
-*- text -*-
+* Redefinition of macros now results in an error.
+
* New command line option -mhint.b=[ok|warning|error] for IA64
targets.
* New command line option -munwind-check=[warning|error] for IA64
---
/home/jbeulich/src/binutils/mainline/2005-03-08/gas/doc/as.texinfo 2005-03-04
15:51:47.000000000 +0100
+++ 2005-03-08/gas/doc/as.texinfo 2005-03-08 10:35:54.158665896
+0100
@@ -4838,8 +4838,10 @@ With that definition, @samp{SUM 0,5} is
Begin the definition of a macro called @var{macname}. If your macro
definition requires arguments, specify their names after the macro
name,
separated by commas or spaces. You can supply a default value for
any
-macro argument by following the name with @samp{=@var{deflt}}. For
-example, these are all valid @code{.macro} statements:
+macro argument by following the name with @samp{=@var{deflt}}. You
+cannot define two macros with the same @var{macname} unless it has
been
+subject to the @code{.purgem} directive (@xref{Purgem}.) between the
two
+definitions. For example, these are all valid @code{.macro}
statements:
@table @code
@item .macro comm
[-- Attachment #2: binutils-mainline-macro-diagnostics-doc.patch --]
[-- Type: text/plain, Size: 1551 bytes --]
gas/
2004-03-08 Jan Beulich <jbeulich@novell.com>
* doc/as.texinfo: Add sentence to indicate redefining a macro is an
error, and point to .purgem documentation if someone really needs
re-definitions.
* NEWS: Mention macro redefinition is now an error.
--- /home/jbeulich/src/binutils/mainline/2005-03-08/gas/NEWS 2005-02-28 08:27:12.000000000 +0100
+++ 2005-03-08/gas/NEWS 2005-03-08 10:14:27.334292936 +0100
@@ -1,5 +1,7 @@
-*- text -*-
+* Redefinition of macros now results in an error.
+
* New command line option -mhint.b=[ok|warning|error] for IA64 targets.
* New command line option -munwind-check=[warning|error] for IA64
--- /home/jbeulich/src/binutils/mainline/2005-03-08/gas/doc/as.texinfo 2005-03-04 15:51:47.000000000 +0100
+++ 2005-03-08/gas/doc/as.texinfo 2005-03-08 10:35:54.158665896 +0100
@@ -4838,8 +4838,10 @@ With that definition, @samp{SUM 0,5} is
Begin the definition of a macro called @var{macname}. If your macro
definition requires arguments, specify their names after the macro name,
separated by commas or spaces. You can supply a default value for any
-macro argument by following the name with @samp{=@var{deflt}}. For
-example, these are all valid @code{.macro} statements:
+macro argument by following the name with @samp{=@var{deflt}}. You
+cannot define two macros with the same @var{macname} unless it has been
+subject to the @code{.purgem} directive (@xref{Purgem}.) between the two
+definitions. For example, these are all valid @code{.macro} statements:
@table @code
@item .macro comm
next reply other threads:[~2005-03-08 9:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-08 9:43 Jan Beulich [this message]
[not found] <s22d7385.022@emea1-mh.id2.novell.com>
2005-03-08 12:44 ` Ian Lance Taylor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s22d7385.021@emea1-mh.id2.novell.com \
--to=jbeulich@novell.com \
--cc=binutils@sources.redhat.com \
--cc=drow@false.org \
--cc=gdb@sources.redhat.com \
--cc=ian@wasabisystems.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).