From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17226 invoked by alias); 23 Jul 2004 14:45:06 -0000 Mailing-List: contact glibc-bugs-regex-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Post: List-Help: , Sender: glibc-bugs-regex-owner@sources.redhat.com Received: (qmail 17199 invoked by uid 48); 23 Jul 2004 14:45:05 -0000 Date: Fri, 23 Jul 2004 14:45:00 -0000 Message-ID: <20040723144505.17197.qmail@sourceware.org> From: "kasal at ucw dot cz" To: glibc-bugs-regex@sources.redhat.com In-Reply-To: <20040723105653.281.kasal@ucw.cz> References: <20040723105653.281.kasal@ucw.cz> Reply-To: sourceware-bugzilla@sources.redhat.com Subject: [Bug regex/281] regex.c doesn't compile on hosts with signed char X-Bugzilla-Reason: CC X-SW-Source: 2004-07/txt/msg00003.txt.bz2 List-Id: ------- Additional Comments From kasal at ucw dot cz 2004-07-23 14:45 ------- (In reply to comment #2) > What kind of problems? > Most of the arches have signed char. > re_search_internal is certainly not the only place which uses > unsigned RE_TRANSLATE_TYPE. When the patch was created, exactly one year ago, this was the only place. (I've submitted the patch to bug-glibc back then, but no answer...) Since then, many bugs were fixed by adding "unsigned" before RE_TRANSLATE_TYPE on many places. > IMHO RE_TRANSLATE_TYPE should stay char *, it has been that way since the > original GNU regex. Well, my opinion has to be humble too, you have read more of regex then I. But I think that it was a mistake originally, which is proved by the rapid growth of "unsigned RE_TRANSLATE_TYPE" which you mentioned. I don't see any problem with the change. -- http://sources.redhat.com/bugzilla/show_bug.cgi?id=281 ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.