From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11793 invoked by alias); 4 Nov 2004 08:59:12 -0000 Mailing-List: contact glibc-bugs-regex-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Post: List-Help: , Sender: glibc-bugs-regex-owner@sources.redhat.com Received: (qmail 11568 invoked by uid 48); 4 Nov 2004 08:59:04 -0000 Date: Thu, 04 Nov 2004 08:59:00 -0000 From: "bonzini at gnu dot org" To: glibc-bugs-regex@sources.redhat.com Message-ID: <20041104085902.506.bonzini@gnu.org> Reply-To: sourceware-bugzilla@sources.redhat.com Subject: [Bug regex/506] New: there is dead code in regex X-Bugzilla-Reason: CC X-SW-Source: 2004-11/txt/msg00012.txt.bz2 List-Id: The flurry of algorithms to efficiently implement backreferences left behind some dead code in regex. The patch at http://sources.redhat.com/ml/libc-alpha/2004-11/msg00016.html removes several unused parameters and struct fields. The most egregious is the "flag" struct re_backref_cache_entry field. Removing it turned a potentially quadratic loop into linear, though I did not try to find a case in which this actually happened. In another case, it looks like changing the algorithms would have required changing the node_set passed to sift_states_bkref, but this was not done. So this patch does that instead of only removing the unused parameter. -- Summary: there is dead code in regex Product: glibc Version: unspecified Status: NEW Severity: normal Priority: P2 Component: regex AssignedTo: bonzini at gnu dot org ReportedBy: bonzini at gnu dot org CC: glibc-bugs-regex at sources dot redhat dot com,glibc- bugs at sources dot redhat dot com OtherBugsDependingO 500 nThis: http://sources.redhat.com/bugzilla/show_bug.cgi?id=506 ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.