public inbox for glibc-bugs-regex@sourceware.org
help / color / mirror / Atom feed
From: "bonzini at gnu dot org" <sourceware-bugzilla@sources.redhat.com>
To: glibc-bugs-regex@sources.redhat.com
Subject: [Bug regex/508] New: check_dst_limits is inefficient
Date: Thu, 04 Nov 2004 09:04:00 -0000	[thread overview]
Message-ID: <20041104090414.508.bonzini@gnu.org> (raw)

This speeds up somewhat the failing test cases for bug 429.

The patch at http://sources.redhat.com/ml/libc-alpha/2004-11/msg00018.html can
already speed up the problematic function by a large amount. 
search_cur_bkref_entry disappears from the profile, and on a reduced testcase
(intermediate between the succeeding and failing testcases)
check_dst_limits_calc_pos is cut to about half the time it used to take.

This is done by hoisting most checks in check_dst_limits_calc_pos out of the
recursive calls, and by optimizing the loops on the backreference cache entries.
   The backreference cache is kept ordered by str_idx, so these loops have two
exit conditions: 1) the backref cache has ended, and 2) we got past this
str_idx.  By flagging the last backreference cache entry for each str_idx, we
can test that there is an entry for our str_idx only on the first iteration (and
sometimes we know there is one), and the flag on every subsequent iteration.

-- 
           Summary: check_dst_limits is inefficient
           Product: glibc
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: regex
        AssignedTo: bonzini at gnu dot org
        ReportedBy: bonzini at gnu dot org
                CC: glibc-bugs-regex at sources dot redhat dot com,glibc-
                    bugs at sources dot redhat dot com
OtherBugsDependingO 429,500
             nThis:


http://sources.redhat.com/bugzilla/show_bug.cgi?id=508

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.


             reply	other threads:[~2004-11-04  9:04 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-11-04  9:04 bonzini at gnu dot org [this message]
2004-11-09  7:55 ` [Bug regex/508] " bonzini at gnu dot org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041104090414.508.bonzini@gnu.org \
    --to=sourceware-bugzilla@sources.redhat.com \
    --cc=glibc-bugs-regex@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).