From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28074 invoked by alias); 19 Apr 2005 01:03:04 -0000 Mailing-List: contact glibc-bugs-regex-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Post: List-Help: , Sender: glibc-bugs-regex-owner@sources.redhat.com Received: (qmail 27753 invoked by uid 48); 19 Apr 2005 01:02:43 -0000 Date: Tue, 19 Apr 2005 01:03:00 -0000 From: "svdb+sources dot redhat dot com-bugs at stack dot nl" To: glibc-bugs-regex@sources.redhat.com Message-ID: <20050419010238.860.svdb+sources.redhat.com-bugs@stack.nl> Reply-To: sourceware-bugzilla@sources.redhat.com Subject: [Bug regex/860] New: bad guard in find_recover_state do-while loop X-Bugzilla-Reason: CC X-SW-Source: 2005-04/txt/msg00000.txt.bz2 List-Id: While compiling the regex code with extra warnings on, from outside libc, quite a lot of warnings were reported. While these warnings were very justified, most of the underlying problems would not cause the actual code to behave in a non- intended way. But one is very much a bug: In find_recover_state, err is compared to REG_NOERROR, while it is *err which should be compared instead. Because of this the do-while loop will always terminate after one iteration. I was working on getting rid of all the warnings in the regex code, which was taking quite a bit of time, as I needed to make sure I'm fixing the actual problems, and not (just) the symptoms. But then I noticed that the GNU coding guidelines stopped just short of saying "Listening to warnings to find a few bugs is not worth the effort.", which would explain the mess I'm encountering. I am willing to continue my work and submit a big patch with fixes that will clean up this code somewhat, but before I continue, I'd like to know whether such a patch will actually stand a chance of getting accepted. -- Summary: bad guard in find_recover_state do-while loop Product: glibc Version: unspecified Status: NEW Severity: normal Priority: P2 Component: regex AssignedTo: gotom at debian dot or dot jp ReportedBy: svdb+sources dot redhat dot com-bugs at stack dot nl CC: glibc-bugs-regex at sources dot redhat dot com,glibc- bugs at sources dot redhat dot com http://sources.redhat.com/bugzilla/show_bug.cgi?id=860 ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.