public inbox for glibc-bugs-regex@sourceware.org help / color / mirror / Atom feed
From: "bonzini at gnu dot org" <sourceware-bugzilla@sourceware.org> To: glibc-bugs-regex@sources.redhat.com Subject: [Bug regex/6395] New: regex ^$ is not detected as anchored Date: Fri, 11 Apr 2008 12:45:00 -0000 [thread overview] Message-ID: <20080411124430.6395.bonzini@gnu.org> (raw) Regex matching has an optimization where only one match is tried for a regex anchored to the beginning of the buffer. While other anchors are resolved with the fastmap, this one allows further optimization and is special cased. However, because of a bug in create_cd_newstate, ^$ would be mistakenly treated as a non-anchoring match, and re_search_internal would try matching it at every position. In fact, the bug is (almost) fixed by this hunk: @@ -1682,8 +1680,6 @@ create_cd_newstate (const re_dfa_t *dfa, newstate->halt = 1; else if (type == OP_BACK_REF) newstate->has_backref = 1; - else if (type == ANCHOR) - constraint = node->opr.ctx_type; if (constraint) { However, some complications in building the NFA prevent this from fixing the problem. Therefore, this patch cleans up the handling of anchors so that tests on type == ANCHOR are not necessary anymore. When creating the NFA (calc_first), I move the opr.ctx_type to the constraint field of re_token_t, and then I always look at it unconditionally, without special-casing ANCHORs. This also allows some simplification of duplicate_node_closure. -- Summary: regex ^$ is not detected as anchored Product: glibc Version: unspecified Status: NEW Severity: enhancement Priority: P2 Component: regex AssignedTo: bonzini at gnu dot org ReportedBy: bonzini at gnu dot org CC: glibc-bugs-regex at sources dot redhat dot com,glibc- bugs at sources dot redhat dot com http://sourceware.org/bugzilla/show_bug.cgi?id=6395 ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
next reply other threads:[~2008-04-11 12:45 UTC|newest] Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top 2008-04-11 12:45 bonzini at gnu dot org [this message] 2008-04-11 12:46 ` [Bug regex/6395] " bonzini at gnu dot org 2008-04-25 14:26 ` bonzini at gnu dot org 2008-05-15 3:08 ` drepper at redhat dot com
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20080411124430.6395.bonzini@gnu.org \ --to=sourceware-bugzilla@sourceware.org \ --cc=glibc-bugs-regex@sources.redhat.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).