public inbox for glibc-bugs-regex@sourceware.org help / color / mirror / Atom feed
From: "nkennedy at grammatech dot com" <sourceware-bugzilla@sourceware.org> To: glibc-bugs-regex@sourceware.org Subject: [Bug regex/16851] New: re_node_set_alloc should not return REG_ESPACE when size == 0 Date: Thu, 17 Apr 2014 22:19:00 -0000 [thread overview] Message-ID: <bug-16851-132@http.sourceware.org/bugzilla/> (raw) https://sourceware.org/bugzilla/show_bug.cgi?id=16851 Bug ID: 16851 Summary: re_node_set_alloc should not return REG_ESPACE when size == 0 Product: glibc Version: unspecified Status: NEW Keywords: std-isoc Severity: normal Priority: P2 Component: regex Assignee: unassigned at sourceware dot org Reporter: nkennedy at grammatech dot com CC: drepper.fsp at gmail dot com, eggert at gnu dot org regcomp fails with REG_ESPACE from re_node_set_alloc if malloc(0) returns NULL. ptmalloc2 malloc(0) doesn't return NULL (unless it's really out of space), but this is allowed by the standard and causes errors when such an allocator is used. This was fixed in gnulib at bbf0d723ed2335add96bcc0f842885d8a5d8b6da: http://git.savannah.gnu.org/gitweb/?p=gnulib.git;a=commitdiff;h=bbf0d723ed2335add96bcc0f842885d8a5d8b6da And previously in uClibc at 4af711dfe8caf18756c2cb28f72b102c5eba3930: http://git.opencores.org/?a=commitdiff&p=uClibc&h=4af711dfe8caf18756c2cb28f72b102c5eba3930 (Despite the commit message, the uClibc patch had not ultimately been applied to sed, rather until bbf0d72... gnulib's regex worked around the error using the malloc-gnu wrapper module.) In the vein of harmonizing glibc/gnulib regex, I'm don't think adding the MALLOC_0_IS_NONNULL macro attempting to check for malloc(0) failure is needed. It should be enough to add "&& size != 0" to regex_internal.c:972 if (BE (set->elems == NULL, 0)) -- You are receiving this mail because: You are on the CC list for the bug.
next reply other threads:[~2014-04-17 22:19 UTC|newest] Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-04-17 22:19 nkennedy at grammatech dot com [this message] 2014-04-18 1:15 ` [Bug regex/16851] " eggert at gnu dot org 2014-04-18 14:37 ` nkennedy at grammatech dot com 2014-04-18 14:56 ` eggert at gnu dot org 2014-06-12 19:40 ` fweimer at redhat dot com
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-16851-132@http.sourceware.org/bugzilla/ \ --to=sourceware-bugzilla@sourceware.org \ --cc=glibc-bugs-regex@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).