From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id 302383857C57; Sat, 10 Oct 2020 10:42:32 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 302383857C57 From: "bruno at clisp dot org" To: glibc-bugs-regex@sourceware.org Subject: [Bug regex/26725] New: regcomp.c uses unusual syntax for function pointers Date: Sat, 10 Oct 2020 10:42:31 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: glibc X-Bugzilla-Component: regex X-Bugzilla-Version: 2.32 X-Bugzilla-Keywords: X-Bugzilla-Severity: minor X-Bugzilla-Who: bruno at clisp dot org X-Bugzilla-Status: UNCONFIRMED X-Bugzilla-Resolution: X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: unassigned at sourceware dot org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version bug_status bug_severity priority component assigned_to reporter cc target_milestone attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: glibc-bugs-regex@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Glibc-bugs-regex mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 10 Oct 2020 10:42:32 -0000 https://sourceware.org/bugzilla/show_bug.cgi?id=3D26725 Bug ID: 26725 Summary: regcomp.c uses unusual syntax for function pointers Product: glibc Version: 2.32 Status: UNCONFIRMED Severity: minor Priority: P2 Component: regex Assignee: unassigned at sourceware dot org Reporter: bruno at clisp dot org CC: drepper.fsp at gmail dot com Target Milestone: --- Created attachment 12895 --> https://sourceware.org/bugzilla/attachment.cgi?id=3D12895&action=3Ded= it Proposed patch regcomp.c uses a syntax for function pointers that I haven't seen in use elsewhere in 20 years. It doesn't ease understanding of the code. Find attached a patch to use the common syntax instead. See Paul Eggert's opinion on this in https://lists.gnu.org/archive/html/bug-gnulib/2020-09/msg00019.html . --=20 You are receiving this mail because: You are on the CC list for the bug.=