From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id EDE023858D20 for ; Mon, 29 Jan 2024 21:22:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EDE023858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org EDE023858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706563371; cv=none; b=IenlgLbS5IkJMsu2OaaucwyY22xkG4XdorRlABAfUmYMHDt1yQZM06xq5DaU7t4AyLVWiuR7JDrYx++VD+d8yulEAwSiyuynz/UvyrOlVmg++9Ki42R1md0YOgNEISGTWCPc4uPvHGWTr+e0ql/7IFNqzk90JZRjJ6suwyykgmM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706563371; c=relaxed/simple; bh=0dM7gHKwr5T/W3gt7TThsJ+6QffHss4Kbh6f9is/8PI=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=PzT6xhH4Sth4Dtg1jpxkZQVZ4NO6oQ59lUW//UueZ4fPsgYG8781W5VeyHkVvB3YBWk7dME0AzwA+N7puu90wMsHFProNez71xGuB1p0hfm3zKI2ChCmQp4GyioNh6xmPcBrtm0VSnn9Si6gI7zx6x5h6VHQij6Upz5vFAfeVZw= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1706563368; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/WNsZfxXb9r7il+xRKd0VYiVY7jLznFitDQY+u/b4CU=; b=PvPuf7YxUv+O+DzVHRMBvY9TjtS2PAL7AFakOfnIvYKEB0RQ9IWMtwyu78eaU76Mk3U6vw UZ3K7A9xCNwwBmhS535WHU1GSEnfgdYPaeEbv6j+pXeyURvZu0HBdWaI1203Aokt7XXnPL NgSxxiqzN49HUFyJzBrkE502wIjfsUw= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-589-17ID8FjQNP-ufPTahuaxkA-1; Mon, 29 Jan 2024 16:22:47 -0500 X-MC-Unique: 17ID8FjQNP-ufPTahuaxkA-1 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-337d6024098so1567984f8f.1 for ; Mon, 29 Jan 2024 13:22:46 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706563366; x=1707168166; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=bYRbyAcqxum1J9uOe4xwFAmp5Y4srb56rsHRzmqtr2E=; b=QEcWxZDqixWEQvjF5m+n0I16BeSO6MrCeI0vg+wtyaa3OMHRRJe7asUChjLBt5VgYo 957E8L7Dlr+GQQ+cNrPo+knYXq6hY7CoAxv4nyH3qLs8A4otLCVVsDLTZQz/BJIL9ASW ieWVeMp0kFbOzIdE5bh+/4hah2pJlLM1CY1eIo+3o4G5BUYQHtM7uBYqOZw0X8bhX1Fb Y31X+McX1ZYRe6yLLRs0iFeSn/j/g74fJ49vOu9J49Np2TwMcl6NX4rqZ+guaNN7H4qS ZQygYMn6GHbPyS6rRjdjh+xP7qYpPsjCreevClk8lWowCHC8lWRqZ6Kzel9Vnu+V2oUi rrXw== X-Gm-Message-State: AOJu0YyLzTL0Q71bpooalSoRjXby4FlXiHW0v3EHZ9inzYCTBjDCSiBf SaCNt0DN/nt9vv+XClsY1YlUh7uxSpGp0XsfJf+YLKp++GBt5kaIXwPPhVR/3wMyQzZXYMbFH9v i8nAy6gsWdO+hnSPd0iUi+5ZKMEhSrrdn9fEmuzHba8D21w/eQzezgHf8SA== X-Received: by 2002:a05:6000:128b:b0:33a:ec23:1a22 with SMTP id f11-20020a056000128b00b0033aec231a22mr3414782wrx.32.1706563366162; Mon, 29 Jan 2024 13:22:46 -0800 (PST) X-Google-Smtp-Source: AGHT+IGuupipGjxumz4sMPgoIRMq5+d3Aqd1LDfEXl0dIchQmr2Xu38A7W4k6TZ7wEth5Kiirm8rGA== X-Received: by 2002:a05:6000:128b:b0:33a:ec23:1a22 with SMTP id f11-20020a056000128b00b0033aec231a22mr3414777wrx.32.1706563365876; Mon, 29 Jan 2024 13:22:45 -0800 (PST) Received: from digraph.polyomino.org.uk (digraph.polyomino.org.uk. [2001:8b0:bf73:93f7::51bb:e332]) by smtp.gmail.com with ESMTPSA id j9-20020a05600c190900b0040ecdd672fasm11123755wmq.13.2024.01.29.13.22.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Jan 2024 13:22:45 -0800 (PST) Received: from jsm28 (helo=localhost) by digraph.polyomino.org.uk with local-esmtp (Exim 4.95) (envelope-from ) id 1rUZ4e-000YwX-0N; Mon, 29 Jan 2024 21:21:48 +0000 Date: Mon, 29 Jan 2024 21:21:47 +0000 (UTC) From: Joseph Myers To: Adhemerval Zanella Netto cc: Ilya Kurdyukov , glibc-bugs@sourceware.org, Wilco Dijkstra Subject: Re: Upstream glibc has a bug in math/e_exp10l.c In-Reply-To: Message-ID: <105f3bad-1a6f-b5c4-c61c-e2e97f64459@redhat.com> References: <9849562b-3fee-4002-87c6-655beb973654@basealt.ru> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/mixed; boundary="-1152306461-579986758-1706563308=:108828" X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. ---1152306461-579986758-1706563308=:108828 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT On Mon, 29 Jan 2024, Adhemerval Zanella Netto via Glibc-bugs wrote: > > Here in math/e_exp10l.c, the name "exp10l" must be used, but this line is copied from math/e_exp10.c and not changed: > > > >   34 libm_alias_finite (__ieee754_exp10, __exp10) > > > > https://sourceware.org/git/?p=glibc.git;a=blob;f=math/e_exp10l.c;h=b33d6fea239ebc20caf8b2dec9b7d03909a0fc81;hb=220622dde5704c95a100c2792a280f18f3deba73#l34 > > It is indeed wrong, although it is not used by any ABI which defines > a long double different than double. Either the sysdep version > (ieee754/ldbl-128ibm, ieee754/ldbl-128) or an arch specific one > (m68k, x86). > > If/once an ABI uses this generic version, it would most likely > generic either an build error (due wrong aliases) or an ABI > issue. Maybe a better option would just to remove this file. I agree with the idea of removing all the math/ implementations that are bogus (don't implement the appropriate semantics with an reasonable accuracy) and overridden for all supported floating-point formats / targets. That includes at least: e_exp10.c e_exp10l.c s_fma.c s_fmaf.c s_fmal.c. -- Joseph S. Myers josmyers@redhat.com ---1152306461-579986758-1706563308=:108828--