From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <glibc-bugs-return-129-listarch-glibc-bugs=sources.redhat.com@sources.redhat.com>
Received: (qmail 25113 invoked by alias); 2 Jun 2004 23:03:19 -0000
Mailing-List: contact glibc-bugs-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:glibc-bugs-subscribe@sources.redhat.com>
List-Post: <mailto:glibc-bugs@sources.redhat.com>
List-Help: <mailto:glibc-bugs-help@sources.redhat.com>, <http://sources.redhat.com/lists.html#faqs>
Sender: glibc-bugs-owner@sources.redhat.com
Received: (qmail 25103 invoked by uid 48); 2 Jun 2004 23:03:17 -0000
Date: Wed, 02 Jun 2004 23:03:00 -0000
From: "miles at cray dot com" <sourceware-bugzilla@sources.redhat.com>
To: glibc-bugs@sources.redhat.com
Message-ID: <20040602230311.200.miles@cray.com>
Reply-To: sourceware-bugzilla@sources.redhat.com
Subject: [Bug libc/200] New: missing parens in define
X-Bugzilla-Reason: CC
X-SW-Source: 2004-06/txt/msg00004.txt.bz2
List-Id: <glibc-bugs.sourceware.org>

In stdlib/gmp-impl.h, there is a #define of the form:
#define ABS(x) (x >= 0 ? x : -x)

It should be

#define ABS(x) ((x) >= 0 ? (x) : -(x))

Otherwise, ABS(n+1) will given an incorrect answer for most negative numbers.

-- 
           Summary: missing parens in define
           Product: glibc
           Version: 2.3.2
            Status: NEW
          Severity: minor
          Priority: P2
         Component: libc
        AssignedTo: gotom at debian dot or dot jp
        ReportedBy: miles at cray dot com
                CC: glibc-bugs at sources dot redhat dot com


http://sources.redhat.com/bugzilla/show_bug.cgi?id=200

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.