[Bug libc/411] New: gcc defines __i686 macro, causing problems in sysdeps/i386/elf/setjmp.S

[Bug libc/411] New: gcc defines __i686 macro, causing problems in sysdeps/i386/elf/setjmp.S

[jsberg04+computing dot glibc at ftml dot net]

Since gcc-3.4.2 (and earlier versions) define the __i686 macro on a pentium3
system, things like __i686.get_pc_thunk.cx get mangled.  Thus,
sysdeps/i386/elf/setjmp.S won't compile on a pentium3 (and presumably pentium2
also).

This is 25 Sep 2004 CVS.

-- 
           Summary: gcc defines __i686 macro, causing problems in
                    sysdeps/i386/elf/setjmp.S
           Product: glibc
           Version: unspecified
            Status: NEW
          Severity: minor
          Priority: P3
         Component: libc
        AssignedTo: gotom at debian dot or dot jp
        ReportedBy: jsberg04+computing dot glibc at ftml dot net
                CC: glibc-bugs at sources dot redhat dot com
 GCC build triplet: i686-pc-linux-gnu
  GCC host triplet: i686-pc-liinux-gnu
GCC target triplet: i686-pc-linux-gnu


http://sources.redhat.com/bugzilla/show_bug.cgi?id=411

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug libc/411] gcc defines __i686 macro, causing problems in sysdeps/i386/elf/setjmp.S

[jsberg04+computing dot glibc at ftml dot net]

------- Additional Comments From jsberg04+computing dot glibc at ftml dot net  2004-10-03 02:00 -------
Created an attachment (id=219)
 --> (http://sources.redhat.com/bugzilla/attachment.cgi?id=219&action=view)
This lets it build for me

This lets is build and everything seems to work.  I'm not sure that this is the
best of the many sysdep.h's to put it in (or even that this is the best thing
to do!).


-- 


http://sources.redhat.com/bugzilla/show_bug.cgi?id=411

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug libc/411] gcc defines __i686 macro, causing problems in sysdeps/i386/elf/setjmp.S

[jsberg04+computing dot glibc at ftml dot net]

------- Additional Comments From jsberg04+computing dot glibc at ftml dot net  2005-04-15 20:29 -------
Created an attachment (id=458)
 --> (http://sources.redhat.com/bugzilla/attachment.cgi?id=458&action=view)
Patch to make it work on NPTL build

I upgraded to kernel 2.6.11.7 and built a nptl glibc (2.3.5 release).  Turns
out the old patch didn't fix things with NPTL.	Things seem to work with this
patch.	Note that I removed the #define from sysdep.h and instead made the
#define's more narrowly targeted.  Also, unstead of #undef'ing __i686, I
defined it to itself as suggested by a message I found on a mailing list
somewhere.

I realized that I'm getting __i686 defined because I configured my gcc-3.4.3
build with --with-cpu=pentium3 --with-arch=pentium3 --with-tune=pentium3.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #219 is|0                           |1
           obsolete|                            |


http://sources.redhat.com/bugzilla/show_bug.cgi?id=411

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug libc/411] gcc defines __i686 macro, causing problems in sysdeps/i386/elf/setjmp.S

[jsberg04+computing dot glibc at ftml dot net]

------- Additional Comments From jsberg04+computing dot glibc at ftml dot net  2005-04-15 20:35 -------
Created an attachment (id=459)
 --> (http://sources.redhat.com/bugzilla/attachment.cgi?id=459&action=view)
Remove tst-cancel17.c patch from the previous

Not paying attention, I left a workaround for the tst-cancel17 problem in that
patch.	New version has it removed.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #458 is|0                           |1
           obsolete|                            |


http://sources.redhat.com/bugzilla/show_bug.cgi?id=411

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug libc/411] gcc defines __i686 macro, causing problems in sysdeps/i386/elf/setjmp.S

[rmathew at gmail dot com]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rmathew at gmail dot com


http://sources.redhat.com/bugzilla/show_bug.cgi?id=411

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug libc/411] gcc defines __i686 macro, causing problems in sysdeps/i386/elf/setjmp.S

[drepper at redhat dot com]

------- Additional Comments From drepper at redhat dot com  2005-10-16 00:41 -------
We don't pass -march=i686 or equivalent to gcc when used on assembler files. 
Unless you do something wrong (like adding the -march parameter to CC or so)
there is no problem.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |WORKSFORME


http://sourceware.org/bugzilla/show_bug.cgi?id=411

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug libc/411] gcc defines __i686 macro, causing problems in sysdeps/i386/elf/setjmp.S

[rmathew at gmail dot com]

------- Additional Comments From rmathew at gmail dot com  2005-10-16 02:05 -------
(In reply to comment #4)
> We don't pass -march=i686 or equivalent to gcc when used on assembler files. 
> Unless you do something wrong (like adding the -march parameter to CC or so)
> there is no problem.

Well, the "-march" bit gets added automatically if the compiler was
built with "--with-arch=pentium3". If I'm building a GCC for use on
only my machine, I would build it like this. The real questions are:

1. Does glibc *really* have to use stuff named "__i686", etc.?

2. What good does GCC achieve by predefining "__i686" when "-march=i686"?

I know you guys are not particularly interested in build failure
reports for glibc, but this particular one seems like something
that can easily be resolved between glibc and GCC.

-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=411

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug libc/411] gcc defines __i686 macro, causing problems in sysdeps/i386/elf/setjmp.S

[jsberg04+computing dot glibc at ftml dot net]

------- Additional Comments From jsberg04+computing dot glibc at ftml dot net  2006-02-07 20:15 -------
Created an attachment (id=859)
 --> (http://sourceware.org/bugzilla/attachment.cgi?id=859&action=view)
Something was wrong with the line numbers in the previous patch, not sure how
that happened...


-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #459 is|0                           |1
           obsolete|                            |


http://sourceware.org/bugzilla/show_bug.cgi?id=411

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug libc/411] gcc defines __i686 macro, causing problems in sysdeps/i386/elf/setjmp.S

[Petr dot Salinger at seznam dot cz]

------- Additional Comments From Petr dot Salinger at seznam dot cz  2006-02-08 09:37 -------
> We don't pass -march=i686 or equivalent to gcc when used on assembler files. 
> Unless you do something wrong (like adding the -march parameter to CC or so)
> there is no problem.

Even if -march is not passed, some predefined macros are used, depending on
compiler target.

Try something like:
touch a.S
gcc -dD a.S -E

Would be possible to use name i.e.
__i686_get_pc_thunk.reg instead of  __i686.get_pc_thunk.reg ?

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
   GCC host triplet|i686-pc-liinux-gnu          |i686-pc-linux-gnu
         Resolution|WORKSFORME                  |


http://sourceware.org/bugzilla/show_bug.cgi?id=411

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug libc/411] gcc defines __i686 macro, causing problems in sysdeps/i386/elf/setjmp.S

[jakub at redhat dot com]

------- Additional Comments From jakub at redhat dot com  2006-02-08 09:42 -------
No, because __i686.get_pc_thunk.* is what GCC uses internally.  Calling it
differently means it can't be merged any longer with GCC created pads.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|                            |WORKSFORME


http://sourceware.org/bugzilla/show_bug.cgi?id=411

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug libc/411] gcc defines __i686 macro, causing problems in sysdeps/i386/elf/setjmp.S

[Petr dot Salinger at seznam dot cz]

------- Additional Comments From Petr dot Salinger at seznam dot cz  2006-02-08 11:14 -------
> No, because __i686.get_pc_thunk.* is what GCC uses internally. 

And what about using patch based on one proposed in
http://sources.redhat.com/ml/libc-alpha/2002-10/msg00157.html

Now it should go into sysdeps/i386/sysdep.h 



-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|WORKSFORME                  |


http://sourceware.org/bugzilla/show_bug.cgi?id=411

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug libc/411] gcc defines __i686 macro, causing problems in sysdeps/i386/elf/setjmp.S

[drepper at redhat dot com]

------- Additional Comments From drepper at redhat dot com  2006-04-21 18:25 -------
"It hurts when I do this."  Then don't.  There is no need for a change.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|                            |INVALID


http://sourceware.org/bugzilla/show_bug.cgi?id=411

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug libc/411] gcc defines __i686 macro, causing problems in sysdeps/i386/elf/setjmp.S

[davem at davemloft dot net]

------- Additional Comments From davem at davemloft dot net  2010-02-24 13:38 -------
Ulrich, it's the default on some distributions, and now even Fedora 12 falls
into this category.

The compiler people or whoever decided to put that __i686 thing into
the CPP namespace made a mistake.  Alternatively a different name for
the getpc thunks could have been chosen.

Either way we're stuck with it and have to address it somehow.  Wishing it
didn't happen won't fix the build failures every single person who tries
to build glibc (with default settings) on Fedora 12 is going to see now.


-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|INVALID                     |


http://sourceware.org/bugzilla/show_bug.cgi?id=411

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug libc/411] gcc defines __i686 macro, causing problems in sysdeps/i386/elf/setjmp.S

[jue at jue dot li]

------- Additional Comments From jue at jue dot li  2010-04-15 08:20 -------
The whole issue became a new quality, because gcc 4.5.0 always set
unconditionally -march=pentiumpro if gcc was build for i686.

Please see my rejected bug report for gcc, 
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43750

-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=411

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug libc/411] gcc defines __i686 macro, causing problems in sysdeps/i386/elf/setjmp.S

[allan at archlinux dot org]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |allan at archlinux dot org


http://sourceware.org/bugzilla/show_bug.cgi?id=411

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.