public inbox for glibc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug libc/573] New: sunrpc/xcrypt.c doesn't work with gcc 4.0
@ 2004-11-24 21:01 hjl@lucon.org
2004-12-03 1:21 ` [Bug libc/573] " gotom at debian dot or dot jp
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: hjl@lucon.org @ 2004-11-24 21:01 UTC (permalink / raw)
To: glibc-bugs
sunrpc/xcrypt.c has
static void passwd2des_internal (char *pw, char *key);
...
static void
passwd2des_internal (char *pw, char *key)
{
...
}
...
strong_alias (passwd2des_internal, passwd2des)
...
It is the same problem mentioned in:
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=15700
That is the extern alias of a static function isn't supported by gcc 4.0
when the static function is inlined.
--
Summary: sunrpc/xcrypt.c doesn't work with gcc 4.0
Product: glibc
Version: unspecified
Status: NEW
Severity: normal
Priority: P2
Component: libc
AssignedTo: gotom at debian dot or dot jp
ReportedBy: hjl at lucon dot org
CC: glibc-bugs at sources dot redhat dot com
http://sources.redhat.com/bugzilla/show_bug.cgi?id=573
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
^ permalink raw reply [flat|nested] 6+ messages in thread* [Bug libc/573] sunrpc/xcrypt.c doesn't work with gcc 4.0
2004-11-24 21:01 [Bug libc/573] New: sunrpc/xcrypt.c doesn't work with gcc 4.0 hjl@lucon.org
@ 2004-12-03 1:21 ` gotom at debian dot or dot jp
2004-12-03 2:40 ` hjl at lucon dot org
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: gotom at debian dot or dot jp @ 2004-12-03 1:21 UTC (permalink / raw)
To: glibc-bugs
------- Additional Comments From gotom at debian dot or dot jp 2004-12-03 01:21 -------
It should be already fixed by aoliva.
http://sources.redhat.com/ml/libc-alpha/2004-07/msg00020.html
--
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
http://sources.redhat.com/bugzilla/show_bug.cgi?id=573
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
^ permalink raw reply [flat|nested] 6+ messages in thread* [Bug libc/573] sunrpc/xcrypt.c doesn't work with gcc 4.0
2004-11-24 21:01 [Bug libc/573] New: sunrpc/xcrypt.c doesn't work with gcc 4.0 hjl@lucon.org
2004-12-03 1:21 ` [Bug libc/573] " gotom at debian dot or dot jp
@ 2004-12-03 2:40 ` hjl at lucon dot org
2004-12-19 15:14 ` aj at suse dot de
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: hjl at lucon dot org @ 2004-12-03 2:40 UTC (permalink / raw)
To: glibc-bugs
------- Additional Comments From hjl at lucon dot org 2004-12-03 02:39 -------
I don't see how
http://sources.redhat.com/ml/libc-alpha/2004-07/msg00020.html
can fix sunrpc/xcrypt.c given that it doesn't touch that file at all.
--
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |REOPENED
Resolution|FIXED |
http://sources.redhat.com/bugzilla/show_bug.cgi?id=573
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
^ permalink raw reply [flat|nested] 6+ messages in thread* [Bug libc/573] sunrpc/xcrypt.c doesn't work with gcc 4.0
2004-11-24 21:01 [Bug libc/573] New: sunrpc/xcrypt.c doesn't work with gcc 4.0 hjl@lucon.org
2004-12-03 1:21 ` [Bug libc/573] " gotom at debian dot or dot jp
2004-12-03 2:40 ` hjl at lucon dot org
@ 2004-12-19 15:14 ` aj at suse dot de
2004-12-19 20:43 ` aj at suse dot de
2004-12-20 19:05 ` hjl at lucon dot org
4 siblings, 0 replies; 6+ messages in thread
From: aj at suse dot de @ 2004-12-19 15:14 UTC (permalink / raw)
To: glibc-bugs
------- Additional Comments From aj at suse dot de 2004-12-19 15:14 -------
I'm testing the appended patch now - could you test it also and tell me
whether it fixes the problem?
2004-12-19 Andreas Jaeger <aj@suse.de>
[BZ #573]
* sunrpc/xcrypt.c (passwd2des_internal): Make it hidden instead of
internal linkage.
============================================================
Index: sunrpc/xcrypt.c
--- sunrpc/xcrypt.c 17 Sep 2002 10:58:00 -0000 1.7
+++ sunrpc/xcrypt.c 19 Dec 2004 15:13:10 -0000
@@ -69,13 +69,15 @@ static char hexval (char) internal_funct
static void hex2bin (int, char *, char *) internal_function;
static void bin2hex (int, unsigned char *, char *) internal_function;
-static void passwd2des_internal (char *pw, char *key);
-
+void passwd2des_internal (char *pw, char *key);
+#ifdef _LIBC
+libc_hidden_proto (passwd2des_internal)
+#endif
/*
* Turn password into DES key
*/
-static void
+void
passwd2des_internal (char *pw, char *key)
{
int i;
@@ -88,6 +90,7 @@ passwd2des_internal (char *pw, char *key
}
#ifdef _LIBC
+libc_hidden_def (passwd2des_internal)
strong_alias (passwd2des_internal, passwd2des)
#else
void passwd2des (char *pw, char *key)
--
What |Removed |Added
----------------------------------------------------------------------------
AssignedTo|gotom at debian dot or dot |aj at suse dot de
|jp |
Status|REOPENED |ASSIGNED
http://sources.redhat.com/bugzilla/show_bug.cgi?id=573
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
^ permalink raw reply [flat|nested] 6+ messages in thread* [Bug libc/573] sunrpc/xcrypt.c doesn't work with gcc 4.0
2004-11-24 21:01 [Bug libc/573] New: sunrpc/xcrypt.c doesn't work with gcc 4.0 hjl@lucon.org
` (2 preceding siblings ...)
2004-12-19 15:14 ` aj at suse dot de
@ 2004-12-19 20:43 ` aj at suse dot de
2004-12-20 19:05 ` hjl at lucon dot org
4 siblings, 0 replies; 6+ messages in thread
From: aj at suse dot de @ 2004-12-19 20:43 UTC (permalink / raw)
To: glibc-bugs
------- Additional Comments From aj at suse dot de 2004-12-19 20:43 -------
Fixed in CVS.
--
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |FIXED
http://sources.redhat.com/bugzilla/show_bug.cgi?id=573
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
^ permalink raw reply [flat|nested] 6+ messages in thread* [Bug libc/573] sunrpc/xcrypt.c doesn't work with gcc 4.0
2004-11-24 21:01 [Bug libc/573] New: sunrpc/xcrypt.c doesn't work with gcc 4.0 hjl@lucon.org
` (3 preceding siblings ...)
2004-12-19 20:43 ` aj at suse dot de
@ 2004-12-20 19:05 ` hjl at lucon dot org
4 siblings, 0 replies; 6+ messages in thread
From: hjl at lucon dot org @ 2004-12-20 19:05 UTC (permalink / raw)
To: glibc-bugs
------- Additional Comments From hjl at lucon dot org 2004-12-20 19:05 -------
Created an attachment (id=315)
--> (http://sources.redhat.com/bugzilla/attachment.cgi?id=315&action=view)
An alternative patch
This alternative patch will allow gcc to inline passwd2des_internal.
--
http://sources.redhat.com/bugzilla/show_bug.cgi?id=573
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2004-12-20 19:05 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-11-24 21:01 [Bug libc/573] New: sunrpc/xcrypt.c doesn't work with gcc 4.0 hjl@lucon.org
2004-12-03 1:21 ` [Bug libc/573] " gotom at debian dot or dot jp
2004-12-03 2:40 ` hjl at lucon dot org
2004-12-19 15:14 ` aj at suse dot de
2004-12-19 20:43 ` aj at suse dot de
2004-12-20 19:05 ` hjl at lucon dot org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).