public inbox for glibc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "jakub at redhat dot com" <sourceware-bugzilla@sources.redhat.com>
To: glibc-bugs@sources.redhat.com
Subject: [Bug math/592] ia64 math library needs updating
Date: Tue, 28 Dec 2004 09:21:00 -0000	[thread overview]
Message-ID: <20041228092132.29784.qmail@sourceware.org> (raw)
In-Reply-To: <20041130055154.592.davidm@hpl.hp.com>


------- Additional Comments From jakub at redhat dot com  2004-12-28 09:21 -------
I don't see sysdeps/ia64/libc_libm_*.S in the patch, that are mentioned
in the ChangeLog as New file.  If they all look like:
#include "libm_X.S" for libc_libm_X.S, then maybe using m_libm_X in
libm-sysdep_routines and libm_X in sysdep_routines could do the job too
(see math/Makefile where it uses this with calls variable).  If this doesn't
work, I think the files belong into sysdeps/ia64/fpu/ directory, not sysdeps/ia64
as ChangeLog entry suggests.

Another thing, have you tried to #include <sysdep.h> in
sysdeps/ia64/fpu/libm-symbols.h and use
#ifdef ASSEMBLER
# define __libm_error_support HIDDEN_JUMPTARGET(__libm_error_support)
instead of
#if defined(ASSEMBLER)
# if defined(_LIBC) && !defined NOT_IN_libc \
     && defined SHARED && defined DO_VERSIONING \
     && !defined HAVE_BROKEN_ALIAS_ATTRIBUTE && !defined NO_HIDDEN
#  define __libm_error_support  __GI___libm_error_support
# endif
?
Otherwise looks good.

-- 


http://sources.redhat.com/bugzilla/show_bug.cgi?id=592

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.


  parent reply	other threads:[~2004-12-28  9:21 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-11-30  5:52 [Bug math/592] New: " davidm@hpl.hp.com
2004-11-30  5:56 ` [Bug math/592] " davidm@hpl.hp.com
2004-11-30  5:58 ` davidm@hpl.hp.com
2004-11-30 11:09 ` schwab@suse.de
2004-12-27 20:48 ` jakub at redhat dot com
2004-12-28  1:39 ` davidm at hpl dot hp dot com
2004-12-28  9:21 ` jakub at redhat dot com [this message]
2004-12-28 20:00 ` davidm at hpl dot hp dot com
2004-12-28 20:00 ` davidm at hpl dot hp dot com
2005-01-06 11:34 ` drepper at redhat dot com
2005-02-16  4:19 ` roland at gnu dot org
2005-02-16 10:05 ` cvs-commit at gcc dot gnu dot org
2005-04-06  0:32 ` cvs-commit at gcc dot gnu dot org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041228092132.29784.qmail@sourceware.org \
    --to=sourceware-bugzilla@sources.redhat.com \
    --cc=glibc-bugs@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).