[Bug libc/700] New: PPC64 set/swapcontext do not restore the CCR

[Bug libc/700] New: PPC64 set/swapcontext do not restore the CCR

[sjmunroe at us dot ibm dot com]

The powerpc64 set/swap context function do not restore the Condition Code
Register  (CCR) due to a typo where the mnemonic for Move from Condition
Register (mfcr) instead of the correct mnemonic mtcr.

Also noticed that the MSR field was being loaded as a word. Should be double
word for 64-bit.

-- 
           Summary: PPC64 set/swapcontext do not restore the CCR
           Product: glibc
           Version: 2.3.4
            Status: NEW
          Severity: critical
          Priority: P2
         Component: libc
        AssignedTo: gotom at debian dot or dot jp
        ReportedBy: sjmunroe at us dot ibm dot com
                CC: glibc-bugs at sources dot redhat dot com
 GCC build triplet: powerpc64-linux
  GCC host triplet: powerpc64-linux
GCC target triplet: powerpc64-linux


http://sources.redhat.com/bugzilla/show_bug.cgi?id=700

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug libc/700] PPC64 set/swapcontext do not restore the CCR

[sjmunroe at us dot ibm dot com]

------- Additional Comments From sjmunroe at us dot ibm dot com  2005-01-31 23:37 -------
Created an attachment (id=391)
 --> (http://sources.redhat.com/bugzilla/attachment.cgi?id=391&action=view)
Patch for PPC64 set/swapcontext CCR restore bug


-- 


http://sources.redhat.com/bugzilla/show_bug.cgi?id=700

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug libc/700] PPC64 set/swapcontext do not restore the CCR

[sjmunroe at us dot ibm dot com]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED


http://sources.redhat.com/bugzilla/show_bug.cgi?id=700

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug libc/700] PPC64 set/swapcontext do not restore the CCR

[sjmunroe at us dot ibm dot com]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|gotom at debian dot or dot  |sjmunroe at us dot ibm dot
                   |jp                          |com


http://sources.redhat.com/bugzilla/show_bug.cgi?id=700

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug libc/700] PPC64 set/swapcontext do not restore the CCR

[sjmunroe at us dot ibm dot com]

------- Additional Comments From sjmunroe at us dot ibm dot com  2005-01-31 23:40 -------
This should also be applied to the 2-3-branch

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://sources.redhat.com/bugzilla/show_bug.cgi?id=700

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug libc/700] PPC64 set/swapcontext do not restore the CCR

[jakub at redhat dot com]

------- Additional Comments From jakub at redhat dot com  2005-02-07 09:02 -------
I don't think this should be RESOLVED/FIXED, given that it has not been
applied to CVS.
Anyway, there are grep lwz.*MSR sysdeps/unix/sysv/linux/powerpc64/*.S
shows 2 occurrences in setcontext.S and 2 in swapcontext.S.  Are you sure you
want to patch just one and not the other one in each of those files?

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |drepper at redhat dot com
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |


http://sources.redhat.com/bugzilla/show_bug.cgi?id=700

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug libc/700] PPC64 set/swapcontext do not restore the CCR

[sjmunroe at us dot ibm dot com]

------- Additional Comments From sjmunroe at us dot ibm dot com  2005-02-07 14:55 -------
Created an attachment (id=396)
 --> (http://sources.redhat.com/bugzilla/attachment.cgi?id=396&action=view)
Improved patch per Jakub


-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #391 is|0                           |1
           obsolete|                            |


http://sources.redhat.com/bugzilla/show_bug.cgi?id=700

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug libc/700] PPC64 set/swapcontext do not restore the CCR

[sjmunroe at us dot ibm dot com]

------- Additional Comments From sjmunroe at us dot ibm dot com  2005-02-07 14:56 -------
Sorry different bugzilla's have different rules. Improved patch above per
Jakub's comments.

-- 


http://sources.redhat.com/bugzilla/show_bug.cgi?id=700

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug libc/700] PPC64 set/swapcontext do not restore the CCR

[sjmunroe at us dot ibm dot com]

------- Additional Comments From sjmunroe at us dot ibm dot com  2005-02-07 14:58 -------
Is it appropriate to assign this bug to myself at thsi point as I am supplying
the fix?

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |ASSIGNED


http://sources.redhat.com/bugzilla/show_bug.cgi?id=700

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug libc/700] PPC64 set/swapcontext do not restore the CCR

[jakub at redhat dot com]

------- Additional Comments From jakub at redhat dot com  2005-02-07 15:05 -------
Looks good to me, except the ChangeLog entry:
1) setcontext.S contains {__novec_,__}setcontext, not *getcontext
2) updating of Copyright year does not belong to ChangeLog, unless the year 
   change is e.g. in the messages printed by some program or library
3) When the description is identical for multiple functions and/or files,
   you should just write it for the first one and use Likewise. for the rest.
So IMHO you want something like:

2005-02-07  Steven Munroe  <sjmunroe@us.ibm.com>

        [BZ #700]
        * sysdeps/unix/sysv/linux/powerpc/powerpc64/setcontext.S
        (__novec_setcontext, __setcontext): Fix a typo so CCR is restored.
        Load MSR as a doubleword.
        * sysdeps/unix/sysv/linux/powerpc/powerpc64/swapcontext.S
        (__novec_swapcontext, __swapcontext): Likewise.

Surely you can assign the bug to yourself, even already when you start
working on the fix to prevent others from duplicating the work.

-- 


http://sources.redhat.com/bugzilla/show_bug.cgi?id=700

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug libc/700] PPC64 set/swapcontext do not restore the CCR

[sjmunroe at us dot ibm dot com]

------- Additional Comments From sjmunroe at us dot ibm dot com  2005-02-07 15:17 -------
Created an attachment (id=397)
 --> (http://sources.redhat.com/bugzilla/attachment.cgi?id=397&action=view)
Newer more improved patch per Jakub

Dyslexics R us... Also may be time for new bifocals ;-)

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #396 is|0                           |1
           obsolete|                            |


http://sources.redhat.com/bugzilla/show_bug.cgi?id=700

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug libc/700] PPC64 set/swapcontext do not restore the CCR

[drepper at redhat dot com]

------- Additional Comments From drepper at redhat dot com  2005-02-07 23:26 -------
Applied.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://sources.redhat.com/bugzilla/show_bug.cgi?id=700

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug libc/700] PPC64 set/swapcontext do not restore the CCR

[roland at gnu dot org]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|                            |724
              nThis|                            |


http://sources.redhat.com/bugzilla/show_bug.cgi?id=700

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug libc/700] PPC64 set/swapcontext do not restore the CCR

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2005-02-16 11:19 -------
Subject: Bug 700

CVSROOT:	/cvs/glibc
Module name:	libc
Branch: 	glibc-2_3-branch
Changes by:	roland@sources.redhat.com	2005-02-16 11:18:21

Modified files:
	sysdeps/unix/sysv/linux/powerpc/powerpc64: setcontext.S 
	                                           swapcontext.S 

Log message:
	2005-02-07  Steven Munroe  <sjmunroe@us.ibm.com>
	
	[BZ #700]
	* sysdeps/unix/sysv/linux/powerpc/powerpc64/setcontext.S
	(__novec_setcontext, __setcontext): Fix typo so CCR is restored.
	Load MSR as a doubleword.
	* sysdeps/unix/sysv/linux/powerpc/powerpc64/swapcontext.S
	(__novec_swapcontext, __swapcontext): Likewise.

Patches:
http://sources.redhat.com/cgi-bin/cvsweb.cgi/libc/sysdeps/unix/sysv/linux/powerpc/powerpc64/setcontext.S.diff?cvsroot=glibc&only_with_tag=glibc-2_3-branch&r1=1.9&r2=1.9.2.1
http://sources.redhat.com/cgi-bin/cvsweb.cgi/libc/sysdeps/unix/sysv/linux/powerpc/powerpc64/swapcontext.S.diff?cvsroot=glibc&only_with_tag=glibc-2_3-branch&r1=1.12&r2=1.12.2.1



-- 


http://sources.redhat.com/bugzilla/show_bug.cgi?id=700

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.