[Bug libc/776] New: Inconsistent struct gconvcache_header

[Bug libc/776] New: Inconsistent struct gconvcache_header

[hjl at lucon dot org]

In iconvconfig.h, there are

typedef uint16_t gidx_t;


struct gconvcache_header
{
  uint32_t magic;
  gidx_t string_offset;
  gidx_t hash_offset;
  gidx_t hash_size;
  gidx_t module_offset;
  gidx_t otherconv_offset;
};

But in iconvconfig.c, there are

/* Format of the output file.

   Offset   Length       Description
   0000     4            Magic header bytes
   0004     4            Offset of string table (stoff)
   0008     4            Offset of name hashing table (hoff)
   000C     4            Hashing table size (hsize)
   0010     4            Offset of module table (moff)
   0014     4            Offset of other conversion module table (ooff)

   stoff    ???          String table

The lengths of stoff, hoff, hsize, moff and ooff are 2 not 4.

Also compiler may put padding in struct gconvcache_header, which may not
be initialized. When write_output does

  iov[0].iov_base = &header;
  iov[0].iov_len = sizeof (struct gconvcache_header);
  total = iov[0].iov_len;

we may get different values in padding for different compilers.

-- 
           Summary: Inconsistent struct gconvcache_header
           Product: glibc
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: libc
        AssignedTo: gotom at debian dot or dot jp
        ReportedBy: hjl at lucon dot org
                CC: glibc-bugs at sources dot redhat dot com


http://sources.redhat.com/bugzilla/show_bug.cgi?id=776

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug libc/776] Inconsistent struct gconvcache_header

[drepper at redhat dot com]

------- Additional Comments From drepper at redhat dot com  2005-03-03 08:28 -------
Fixed in CVS.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED


http://sources.redhat.com/bugzilla/show_bug.cgi?id=776

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug libc/776] Inconsistent struct gconvcache_header

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2005-03-03 16:28 -------
Subject: Bug 776

CVSROOT:	/cvs/glibc
Module name:	libc
Branch: 	fedora-2_3-branch
Changes by:	jakub@sources.redhat.com	2005-03-03 16:27:44

Modified files:
	.              : ChangeLog 
	iconv          : iconvconfig.c 

Log message:
	[BZ #776]
	* iconv/iconvconfig.c: Fix comment for the output file.
	(write_output): Clear padding in header.

Patches:
http://sources.redhat.com/cgi-bin/cvsweb.cgi/libc/ChangeLog.diff?cvsroot=glibc&only_with_tag=fedora-2_3-branch&r1=1.8782.2.67.2.4&r2=1.8782.2.67.2.5
http://sources.redhat.com/cgi-bin/cvsweb.cgi/libc/iconv/iconvconfig.c.diff?cvsroot=glibc&only_with_tag=fedora-2_3-branch&r1=1.19.2.2.2.1&r2=1.19.2.2.2.2



-- 


http://sources.redhat.com/bugzilla/show_bug.cgi?id=776

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug libc/776] Inconsistent struct gconvcache_header

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2005-04-06 00:38 -------
Subject: Bug 776

CVSROOT:	/cvs/glibc
Module name:	libc
Branch: 	glibc-2_3-branch
Changes by:	roland@sources.redhat.com	2005-04-06 00:37:53

Modified files:
	iconv          : iconvconfig.c 

Log message:
	2005-03-01  H.J. Lu  <hongjiu.lu@intel.com>
	
	[BZ #776]
	* iconv/iconvconfig.c: Fix comment for the output file.
	(write_output): Clear padding in header.

Patches:
http://sources.redhat.com/cgi-bin/cvsweb.cgi/libc/iconv/iconvconfig.c.diff?cvsroot=glibc&only_with_tag=glibc-2_3-branch&r1=1.21.2.1&r2=1.21.2.2



-- 


http://sources.redhat.com/bugzilla/show_bug.cgi?id=776

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug libc/776] Inconsistent struct gconvcache_header

[roland at gnu dot org]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|                            |724
              nThis|                            |


http://sources.redhat.com/bugzilla/show_bug.cgi?id=776

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.