public inbox for glibc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug libc/1051] New: __BEGIN_NAMESPACE_STD / __END_NAMESPACE_C99
@ 2005-07-06  5:44 suckfish at ihug dot co dot nz
  2005-07-06  5:47 ` [Bug libc/1051] " suckfish at ihug dot co dot nz
  2005-09-17 17:28 ` drepper at redhat dot com
  0 siblings, 2 replies; 3+ messages in thread
From: suckfish at ihug dot co dot nz @ 2005-07-06  5:44 UTC (permalink / raw)
  To: glibc-bugs

In stdlib.h one occurrence of __BEGIN_NAMESPACE_STD before strtol/strtoul is
paired with __END_NAMESPACE_C99.

I assume that the intention was for it to be paired with __END_NAMESPACE_STD
even if it makes no difference in practice.

Also, there is an apparently extraneous __END_NAMESPACE_C99 in wctype.h

Patch below.

diff -u /usr/include/stdlib.h ./stdlib.h
--- /usr/include/stdlib.h       2005-05-30 23:11:20.000000000 +1200
+++ ./stdlib.h  2005-07-06 11:47:41.000000000 +1200
@@ -188,7 +188,7 @@
 extern unsigned long int strtoul (__const char *__restrict __nptr,
                                  char **__restrict __endptr, int __base)
      __THROW __nonnull ((1)) __wur;
-__END_NAMESPACE_C99
+__END_NAMESPACE_STD
 
 #if defined __GLIBC_HAVE_LONG_LONG && defined __USE_BSD
 /* Convert a string to a quadword integer.  */
diff -u /usr/include/wctype.h ./wctype.h
--- /usr/include/wctype.h       2005-05-30 23:11:43.000000000 +1200
+++ ./wctype.h  2005-07-06 11:50:42.000000000 +1200
@@ -44,7 +44,6 @@
 #  ifdef __USE_ISOC99
 __USING_NAMESPACE_C99(wint_t)
 #  endif
-__END_NAMESPACE_C99
 # endif
 
 /* Constant expression of type `wint_t' whose value does not correspond

-- 
           Summary: __BEGIN_NAMESPACE_STD / __END_NAMESPACE_C99
           Product: glibc
           Version: unspecified
            Status: NEW
          Severity: minor
          Priority: P2
         Component: libc
        AssignedTo: gotom at debian dot or dot jp
        ReportedBy: suckfish at ihug dot co dot nz
                CC: glibc-bugs at sources dot redhat dot com


http://sources.redhat.com/bugzilla/show_bug.cgi?id=1051

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Bug libc/1051] __BEGIN_NAMESPACE_STD / __END_NAMESPACE_C99
  2005-07-06  5:44 [Bug libc/1051] New: __BEGIN_NAMESPACE_STD / __END_NAMESPACE_C99 suckfish at ihug dot co dot nz
@ 2005-07-06  5:47 ` suckfish at ihug dot co dot nz
  2005-09-17 17:28 ` drepper at redhat dot com
  1 sibling, 0 replies; 3+ messages in thread
From: suckfish at ihug dot co dot nz @ 2005-07-06  5:47 UTC (permalink / raw)
  To: glibc-bugs


------- Additional Comments From suckfish at ihug dot co dot nz  2005-07-06 05:47 -------
Created an attachment (id=545)
 --> (http://sources.redhat.com/bugzilla/attachment.cgi?id=545&action=view)
A perl script to check pairing of __BEGIN ... __END strings.

I wrote a small perl script to check such things.  Takes a list of file names
on the command line.  Use as you wish.

-- 


http://sources.redhat.com/bugzilla/show_bug.cgi?id=1051

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Bug libc/1051] __BEGIN_NAMESPACE_STD / __END_NAMESPACE_C99
  2005-07-06  5:44 [Bug libc/1051] New: __BEGIN_NAMESPACE_STD / __END_NAMESPACE_C99 suckfish at ihug dot co dot nz
  2005-07-06  5:47 ` [Bug libc/1051] " suckfish at ihug dot co dot nz
@ 2005-09-17 17:28 ` drepper at redhat dot com
  1 sibling, 0 replies; 3+ messages in thread
From: drepper at redhat dot com @ 2005-09-17 17:28 UTC (permalink / raw)
  To: glibc-bugs


------- Additional Comments From drepper at redhat dot com  2005-09-17 17:28 -------
I applied the patches and added the script in a slightly changed form.  Thanks.

Next time don't forget to add a ChangeLog entry.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED


http://sourceware.org/bugzilla/show_bug.cgi?id=1051

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2005-09-17 17:28 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-07-06  5:44 [Bug libc/1051] New: __BEGIN_NAMESPACE_STD / __END_NAMESPACE_C99 suckfish at ihug dot co dot nz
2005-07-06  5:47 ` [Bug libc/1051] " suckfish at ihug dot co dot nz
2005-09-17 17:28 ` drepper at redhat dot com

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).