[Bug libc/961] New: sendfile() and sendfile64() wrongly have __nonnull((3)) declaration

[Bug libc/961] New: sendfile() and sendfile64() wrongly have __nonnull((3)) declaration

[ldv at altlinux dot org]

In io/sys/sendfile.h, declarations of sendfile() and sendfile64() have
__THROW __nonnull ((3))
However, in the comment few lines above the sendfile() declaration you can
read: "If OFFSET is a null pointer, use the normal file position instead."
Therefore these __nonnul declarations appear to be incorrect and should
be removed.

-- 
           Summary: sendfile() and sendfile64() wrongly have __nonnull((3))
                    declaration
           Product: glibc
           Version: 2.3.5
            Status: NEW
          Severity: normal
          Priority: P2
         Component: libc
        AssignedTo: roland at gnu dot org
        ReportedBy: ldv at altlinux dot org
                CC: glibc-bugs at sources dot redhat dot com
OtherBugsDependingO 852
             nThis:


http://sources.redhat.com/bugzilla/show_bug.cgi?id=961

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug libc/961] sendfile() and sendfile64() wrongly have __nonnull((3)) declaration

[ldv at altlinux dot org]

------- Additional Comments From ldv at altlinux dot org  2005-05-22 22:33 -------
Created an attachment (id=492)
 --> (http://sources.redhat.com/bugzilla/attachment.cgi?id=492&action=view)
glibc-alt-sendfile.patch

Proposed fix.

-- 


http://sources.redhat.com/bugzilla/show_bug.cgi?id=961

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug libc/961] sendfile() and sendfile64() wrongly have __nonnull((3)) declaration

[jakub at redhat dot com]

------- Additional Comments From jakub at redhat dot com  2005-05-22 22:52 -------
Patches should be mailed to libc-alpha@sources.redhat.com.  Thanks.
This one looks good to me.

-- 


http://sources.redhat.com/bugzilla/show_bug.cgi?id=961

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug libc/961] sendfile() and sendfile64() wrongly have __nonnull((3)) declaration

[ldv at altlinux dot org]

------- Additional Comments From ldv at altlinux dot org  2005-05-22 22:59 -------
Strictly speaking, this is rather bug report with proposed fix than patch. :)
Should me duplicate the patch to libc-alpha@ mailing list?

-- 


http://sources.redhat.com/bugzilla/show_bug.cgi?id=961

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug libc/961] sendfile() and sendfile64() wrongly have __nonnull((3)) declaration

[jakub at redhat dot com]

------- Additional Comments From jakub at redhat dot com  2005-05-22 23:07 -------
Yes, libc-alpha is the right place to post patches.

-- 


http://sources.redhat.com/bugzilla/show_bug.cgi?id=961

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug libc/961] sendfile() and sendfile64() wrongly have __nonnull((3)) declaration

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2005-05-23 14:29 -------
Subject: Bug 961

CVSROOT:	/cvs/glibc
Module name:	libc
Branch: 	fedora-branch
Changes by:	jakub@sources.redhat.com	2005-05-23 14:28:30

Modified files:
	.              : ChangeLog 
	io/sys         : sendfile.h 

Log message:
	2005-05-22  Dmitry V. Levin  <ldv@altlinux.org>
	
	[BZ #961]
	* io/sys/sendfile.h: Remove __nonnull from sendfile and sendfile64
	declarations.

Patches:
http://sources.redhat.com/cgi-bin/cvsweb.cgi/libc/ChangeLog.diff?cvsroot=glibc&only_with_tag=fedora-branch&r1=1.8782.2.103&r2=1.8782.2.104
http://sources.redhat.com/cgi-bin/cvsweb.cgi/libc/io/sys/sendfile.h.diff?cvsroot=glibc&only_with_tag=fedora-branch&r1=1.4&r2=1.4.2.1



-- 


http://sources.redhat.com/bugzilla/show_bug.cgi?id=961

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug libc/961] sendfile() and sendfile64() wrongly have __nonnull((3)) declaration

[drepper at redhat dot com]

------- Additional Comments From drepper at redhat dot com  2005-05-23 17:38 -------
Patch in trunk.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED


http://sources.redhat.com/bugzilla/show_bug.cgi?id=961

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug libc/961] sendfile() and sendfile64() wrongly have __nonnull((3)) declaration

[roland at gnu dot org]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|852                         |
              nThis|                            |


http://sources.redhat.com/bugzilla/show_bug.cgi?id=961

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug libc/961] sendfile() and sendfile64() wrongly have __nonnull((3)) declaration

[roland at gnu dot org]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|                            |852
              nThis|                            |


http://sources.redhat.com/bugzilla/show_bug.cgi?id=961

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug libc/961] sendfile() and sendfile64() wrongly have __nonnull((3)) declaration

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2005-07-18 01:42 -------
Subject: Bug 961

CVSROOT:	/cvs/glibc
Module name:	libc
Branch: 	glibc-2_3-branch
Changes by:	roland@sources.redhat.com	2005-07-18 01:42:48

Modified files:
	io/sys         : sendfile.h 

Log message:
	2005-05-22  Dmitry V. Levin  <ldv@altlinux.org>
	
	[BZ #961]
	* io/sys/sendfile.h: Remove __nonnull from sendfile and sendfile64
	declarations.

Patches:
http://sources.redhat.com/cgi-bin/cvsweb.cgi/libc/io/sys/sendfile.h.diff?cvsroot=glibc&only_with_tag=glibc-2_3-branch&r1=1.4&r2=1.4.4.1



-- 


http://sources.redhat.com/bugzilla/show_bug.cgi?id=961

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.