public inbox for glibc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "simon at josefsson dot org" <sourceware-bugzilla@sourceware.org>
To: glibc-bugs@sources.redhat.com
Subject: [Bug libc/538] Improvement to getaddrinfo gai_strerror.c to make it usable in gnulib
Date: Fri, 23 Sep 2005 13:44:00 -0000 [thread overview]
Message-ID: <20050923134400.26380.qmail@sourceware.org> (raw)
In-Reply-To: <20041110184141.538.simon@josefsson.org>
------- Additional Comments From simon at josefsson dot org 2005-09-23 13:43 -------
(In reply to comment #2)
> It is always wrong to use __USE_GNU in non-header files. The file must simply
> be defined so that the definitions of the values are visible in the header.
How about this patch? It sync with current gnulib CVS, and hide the non-POSIX
EAI_* values inside a #if EAI_IDN_ENCODE test.
Index: gai_strerror.c
===================================================================
RCS file: /cvs/glibc/libc/sysdeps/posix/gai_strerror.c,v
retrieving revision 1.7
diff -u -p -r1.7 gai_strerror.c
--- gai_strerror.c 8 Mar 2004 22:21:13 -0000 1.7
+++ gai_strerror.c 23 Sep 2005 13:41:31 -0000
@@ -1,4 +1,4 @@
-/* Copyright (C) 1997, 2001, 2002, 2004 Free Software Foundation, Inc.
+/* Copyright (C) 1997, 2001, 2002, 2004, 2005 Free Software Foundation, Inc.
This file is part of the GNU C Library.
Contributed by Philip Blundell <pjb27@cam.ac.uk>, 1997.
@@ -17,9 +17,24 @@
Software Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA
02111-1307 USA. */
+#ifdef HAVE_CONFIG_H
+# include <config.h>
+#endif
+
+#ifndef _LIBC
+# include "getaddrinfo.h"
+#endif
+
#include <stdio.h>
#include <netdb.h>
-#include <libintl.h>
+
+#ifdef _LIBC
+# include <libintl.h>
+#else
+# include "gettext.h"
+# define _(String) gettext (String)
+# define N_(String) String
+#endif
static struct
{
@@ -39,12 +54,14 @@ values[] =
{ EAI_SERVICE, N_("Servname not supported for ai_socktype") },
{ EAI_SOCKTYPE, N_("ai_socktype not supported") },
{ EAI_SYSTEM, N_("System error") },
+#ifdef EAI_IDN_ENCODE
{ EAI_INPROGRESS, N_("Processing request in progress") },
{ EAI_CANCELED, N_("Request canceled") },
{ EAI_NOTCANCELED, N_("Request not canceled") },
{ EAI_ALLDONE, N_("All requests done") },
{ EAI_INTR, N_("Interrupted by a signal") },
{ EAI_IDN_ENCODE, N_("Parameter string not correctly encoded") }
+#endif
};
const char *
@@ -57,4 +74,6 @@ gai_strerror (int code)
return _("Unknown error");
}
+#ifdef _LIBC
libc_hidden_def (gai_strerror)
+#endif
--
http://sourceware.org/bugzilla/show_bug.cgi?id=538
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
next prev parent reply other threads:[~2005-09-23 13:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-10 18:42 [Bug libc/538] New: " simon@josefsson.org
2004-12-03 1:50 ` [Bug libc/538] " gotom at debian dot or dot jp
2005-09-23 0:53 ` drepper at redhat dot com
2005-09-23 13:44 ` simon at josefsson dot org [this message]
2005-09-23 13:47 ` simon at josefsson dot org
2005-10-15 5:16 ` drepper at redhat dot com
2006-04-25 18:13 ` drepper at redhat dot com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050923134400.26380.qmail@sourceware.org \
--to=sourceware-bugzilla@sourceware.org \
--cc=glibc-bugs@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).