public inbox for glibc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "simon at josefsson dot org" <sourceware-bugzilla@sourceware.org>
To: glibc-bugs@sources.redhat.com
Subject: [Bug libc/538] Improvement to getaddrinfo gai_strerror.c to make it usable in gnulib
Date: Fri, 23 Sep 2005 13:47:00 -0000 [thread overview]
Message-ID: <20050923134701.27624.qmail@sourceware.org> (raw)
In-Reply-To: <20041110184141.538.simon@josefsson.org>
------- Additional Comments From simon at josefsson dot org 2005-09-23 13:46 -------
(In reply to comment #3)
> (In reply to comment #2)
> > It is always wrong to use __USE_GNU in non-header files. The file must simply
> > be defined so that the definitions of the values are visible in the header.
>
> How about this patch? It sync with current gnulib CVS, and hide the non-POSIX
> EAI_* values inside a #if EAI_IDN_ENCODE test.
Updated changelog entry:
2005-09-23 Simon Josefsson <jas@extundo.com>
* sysdeps/posix/gai_strerror.c [_LIBC]: Make #include <libintl.h>
conditional on _LIBC.
[!_LIBC]: Include getaddrinfo.h, gettext.h and define _ and N_,
for when the file is used in gnulib.
[__EAI_IDN_ENCODE]: Only use EAI_INPROGRESS, EAI_CANCELED,
EAI_NOTCANCELED, EAI_ALLDONE, EAI_INTR, and EAI_IDN_ENCODE when
EAI_IDN_ENCODE is defined, to make the file work on non-GNU systems.
[_LIBC]: Make libc_hidden_def conditional on _LIBC.
[HAVE_CONFIG_H]: Include config.h, for gnulib.
--
http://sourceware.org/bugzilla/show_bug.cgi?id=538
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
next prev parent reply other threads:[~2005-09-23 13:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-10 18:42 [Bug libc/538] New: " simon@josefsson.org
2004-12-03 1:50 ` [Bug libc/538] " gotom at debian dot or dot jp
2005-09-23 0:53 ` drepper at redhat dot com
2005-09-23 13:44 ` simon at josefsson dot org
2005-09-23 13:47 ` simon at josefsson dot org [this message]
2005-10-15 5:16 ` drepper at redhat dot com
2006-04-25 18:13 ` drepper at redhat dot com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050923134701.27624.qmail@sourceware.org \
--to=sourceware-bugzilla@sourceware.org \
--cc=glibc-bugs@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).