* [Bug hurd/1254] getpeername(fd,NULL,&len) crashes even if len==0
[not found] <20050826230859.1254.tschwinge@gnu.org>
@ 2005-10-16 10:09 ` cvs-commit at gcc dot gnu dot org
2005-10-16 10:10 ` roland at gnu dot org
` (9 subsequent siblings)
10 siblings, 0 replies; 11+ messages in thread
From: cvs-commit at gcc dot gnu dot org @ 2005-10-16 10:09 UTC (permalink / raw)
To: glibc-bugs
------- Additional Comments From cvs-commit at gcc dot gnu dot org 2005-10-16 10:09 -------
Subject: Bug 1254
CVSROOT: /cvs/glibc
Module name: libc
Changes by: roland@sources.redhat.com 2005-10-16 10:09:30
Modified files:
sysdeps/mach/hurd: getpeername.c
Log message:
2005-10-16 Roland McGrath <roland@frob.com>
[BZ #1254]
* sysdeps/mach/hurd/getpeername.c (__getpeername): Respect *LEN
byte limit when setting ADDR->sa_family.
Reported by Samuel Thibault <samuel.thibault@ens-lyon.org>.
Patches:
http://sources.redhat.com/cgi-bin/cvsweb.cgi/libc/sysdeps/mach/hurd/getpeername.c.diff?cvsroot=glibc&r1=1.11&r2=1.12
--
http://sourceware.org/bugzilla/show_bug.cgi?id=1254
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
^ permalink raw reply [flat|nested] 11+ messages in thread* [Bug hurd/1254] getpeername(fd,NULL,&len) crashes even if len==0
[not found] <20050826230859.1254.tschwinge@gnu.org>
2005-10-16 10:09 ` [Bug hurd/1254] getpeername(fd,NULL,&len) crashes even if len==0 cvs-commit at gcc dot gnu dot org
@ 2005-10-16 10:10 ` roland at gnu dot org
2005-10-17 22:57 ` samuel dot thibault at ens-lyon dot org
` (8 subsequent siblings)
10 siblings, 0 replies; 11+ messages in thread
From: roland at gnu dot org @ 2005-10-16 10:10 UTC (permalink / raw)
To: glibc-bugs
------- Additional Comments From roland at gnu dot org 2005-10-16 10:10 -------
I checked in a different change. Please verify that it works right and then
I'll put it on the 2.3 branch as well.
--
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |WAITING
http://sourceware.org/bugzilla/show_bug.cgi?id=1254
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
^ permalink raw reply [flat|nested] 11+ messages in thread* [Bug hurd/1254] getpeername(fd,NULL,&len) crashes even if len==0
[not found] <20050826230859.1254.tschwinge@gnu.org>
2005-10-16 10:09 ` [Bug hurd/1254] getpeername(fd,NULL,&len) crashes even if len==0 cvs-commit at gcc dot gnu dot org
2005-10-16 10:10 ` roland at gnu dot org
@ 2005-10-17 22:57 ` samuel dot thibault at ens-lyon dot org
2005-10-17 22:59 ` samuel dot thibault at ens-lyon dot org
` (7 subsequent siblings)
10 siblings, 0 replies; 11+ messages in thread
From: samuel dot thibault at ens-lyon dot org @ 2005-10-17 22:57 UTC (permalink / raw)
To: glibc-bugs
------- Additional Comments From samuel dot thibault at ens-lyon dot org 2005-10-17 22:57 -------
Hi, It doesn't work, because the af_family is not the first of the structure (there is af_len too), so that in getpeername(fd,NULL, 0), *len - offsetof(struct sockaddr, sa_family) becomes negative.
--
http://sourceware.org/bugzilla/show_bug.cgi?id=1254
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
^ permalink raw reply [flat|nested] 11+ messages in thread* [Bug hurd/1254] getpeername(fd,NULL,&len) crashes even if len==0
[not found] <20050826230859.1254.tschwinge@gnu.org>
` (2 preceding siblings ...)
2005-10-17 22:57 ` samuel dot thibault at ens-lyon dot org
@ 2005-10-17 22:59 ` samuel dot thibault at ens-lyon dot org
2005-10-17 23:00 ` samuel dot thibault at ens-lyon dot org
` (6 subsequent siblings)
10 siblings, 0 replies; 11+ messages in thread
From: samuel dot thibault at ens-lyon dot org @ 2005-10-17 22:59 UTC (permalink / raw)
To: glibc-bugs
------- Additional Comments From samuel dot thibault at ens-lyon dot org 2005-10-17 22:59 -------
Created an attachment (id=717)
--> (http://sourceware.org/bugzilla/attachment.cgi?id=717&action=view)
Updated patch, not tested yet
--
http://sourceware.org/bugzilla/show_bug.cgi?id=1254
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
^ permalink raw reply [flat|nested] 11+ messages in thread* [Bug hurd/1254] getpeername(fd,NULL,&len) crashes even if len==0
[not found] <20050826230859.1254.tschwinge@gnu.org>
` (3 preceding siblings ...)
2005-10-17 22:59 ` samuel dot thibault at ens-lyon dot org
@ 2005-10-17 23:00 ` samuel dot thibault at ens-lyon dot org
2005-10-18 18:25 ` samuel dot thibault at ens-lyon dot org
` (5 subsequent siblings)
10 siblings, 0 replies; 11+ messages in thread
From: samuel dot thibault at ens-lyon dot org @ 2005-10-17 23:00 UTC (permalink / raw)
To: glibc-bugs
------- Additional Comments From samuel dot thibault at ens-lyon dot org 2005-10-17 23:00 -------
Created an attachment (id=718)
--> (http://sourceware.org/bugzilla/attachment.cgi?id=718&action=view)
Grrmbl, sorry, here is the real corrected patch. Not tested either
--
What |Removed |Added
----------------------------------------------------------------------------
Attachment #717 is|0 |1
obsolete| |
http://sourceware.org/bugzilla/show_bug.cgi?id=1254
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
^ permalink raw reply [flat|nested] 11+ messages in thread* [Bug hurd/1254] getpeername(fd,NULL,&len) crashes even if len==0
[not found] <20050826230859.1254.tschwinge@gnu.org>
` (4 preceding siblings ...)
2005-10-17 23:00 ` samuel dot thibault at ens-lyon dot org
@ 2005-10-18 18:25 ` samuel dot thibault at ens-lyon dot org
2005-10-23 0:46 ` cvs-commit at gcc dot gnu dot org
` (4 subsequent siblings)
10 siblings, 0 replies; 11+ messages in thread
From: samuel dot thibault at ens-lyon dot org @ 2005-10-18 18:25 UTC (permalink / raw)
To: glibc-bugs
------- Additional Comments From samuel dot thibault at ens-lyon dot org 2005-10-18 18:25 -------
That last patch does work as expected.
--
http://sourceware.org/bugzilla/show_bug.cgi?id=1254
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
^ permalink raw reply [flat|nested] 11+ messages in thread* [Bug hurd/1254] getpeername(fd,NULL,&len) crashes even if len==0
[not found] <20050826230859.1254.tschwinge@gnu.org>
` (5 preceding siblings ...)
2005-10-18 18:25 ` samuel dot thibault at ens-lyon dot org
@ 2005-10-23 0:46 ` cvs-commit at gcc dot gnu dot org
2005-10-23 0:53 ` cvs-commit at gcc dot gnu dot org
` (3 subsequent siblings)
10 siblings, 0 replies; 11+ messages in thread
From: cvs-commit at gcc dot gnu dot org @ 2005-10-23 0:46 UTC (permalink / raw)
To: glibc-bugs
------- Additional Comments From cvs-commit at gcc dot gnu dot org 2005-10-23 00:46 -------
Subject: Bug 1254
CVSROOT: /cvs/glibc
Module name: libc
Changes by: roland@sources.redhat.com 2005-10-23 00:46:36
Modified files:
sysdeps/mach/hurd: getpeername.c
Log message:
2005-10-22 Roland McGrath <roland@redhat.com>
[BZ #1254]
* sysdeps/mach/hurd/getpeername.c (__getpeername): Fix last change.
From Samuel Thibault <samuel.thibault@ens-lyon.org>.
Patches:
http://sources.redhat.com/cgi-bin/cvsweb.cgi/libc/sysdeps/mach/hurd/getpeername.c.diff?cvsroot=glibc&r1=1.12&r2=1.13
--
http://sourceware.org/bugzilla/show_bug.cgi?id=1254
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
^ permalink raw reply [flat|nested] 11+ messages in thread* [Bug hurd/1254] getpeername(fd,NULL,&len) crashes even if len==0
[not found] <20050826230859.1254.tschwinge@gnu.org>
` (6 preceding siblings ...)
2005-10-23 0:46 ` cvs-commit at gcc dot gnu dot org
@ 2005-10-23 0:53 ` cvs-commit at gcc dot gnu dot org
2005-10-23 0:57 ` roland at gnu dot org
` (2 subsequent siblings)
10 siblings, 0 replies; 11+ messages in thread
From: cvs-commit at gcc dot gnu dot org @ 2005-10-23 0:53 UTC (permalink / raw)
To: glibc-bugs
------- Additional Comments From cvs-commit at gcc dot gnu dot org 2005-10-23 00:53 -------
Subject: Bug 1254
CVSROOT: /cvs/glibc
Module name: libc
Branch: glibc-2_3-branch
Changes by: roland@sources.redhat.com 2005-10-23 00:53:24
Modified files:
sysdeps/mach/hurd: getpeername.c
Log message:
2005-10-22 Roland McGrath <roland@frob.com>
[BZ #1254]
* sysdeps/mach/hurd/getpeername.c (__getpeername): Fix last change.
From Samuel Thibault <samuel.thibault@ens-lyon.org>.
2005-10-16 Roland McGrath <roland@frob.com>
[BZ #1254]
* sysdeps/mach/hurd/getpeername.c (__getpeername): Respect *LEN
byte limit when setting ADDR->sa_family.
Reported by Samuel Thibault <samuel.thibault@ens-lyon.org>.
Patches:
http://sources.redhat.com/cgi-bin/cvsweb.cgi/libc/sysdeps/mach/hurd/getpeername.c.diff?cvsroot=glibc&only_with_tag=glibc-2_3-branch&r1=1.11&r2=1.11.6.1
--
http://sourceware.org/bugzilla/show_bug.cgi?id=1254
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
^ permalink raw reply [flat|nested] 11+ messages in thread* [Bug hurd/1254] getpeername(fd,NULL,&len) crashes even if len==0
[not found] <20050826230859.1254.tschwinge@gnu.org>
` (7 preceding siblings ...)
2005-10-23 0:53 ` cvs-commit at gcc dot gnu dot org
@ 2005-10-23 0:57 ` roland at gnu dot org
2005-10-23 1:01 ` roland at gnu dot org
2005-10-23 22:11 ` samuel dot thibault at ens-lyon dot org
10 siblings, 0 replies; 11+ messages in thread
From: roland at gnu dot org @ 2005-10-23 0:57 UTC (permalink / raw)
To: glibc-bugs
------- Additional Comments From roland at gnu dot org 2005-10-23 00:57 -------
Thanks for the braino fix. It's in on both branches.
Please verify that everything is good.
--
http://sourceware.org/bugzilla/show_bug.cgi?id=1254
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
^ permalink raw reply [flat|nested] 11+ messages in thread* [Bug hurd/1254] getpeername(fd,NULL,&len) crashes even if len==0
[not found] <20050826230859.1254.tschwinge@gnu.org>
` (8 preceding siblings ...)
2005-10-23 0:57 ` roland at gnu dot org
@ 2005-10-23 1:01 ` roland at gnu dot org
2005-10-23 22:11 ` samuel dot thibault at ens-lyon dot org
10 siblings, 0 replies; 11+ messages in thread
From: roland at gnu dot org @ 2005-10-23 1:01 UTC (permalink / raw)
To: glibc-bugs
--
What |Removed |Added
----------------------------------------------------------------------------
OtherBugsDependingO| |852
nThis| |
http://sourceware.org/bugzilla/show_bug.cgi?id=1254
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
^ permalink raw reply [flat|nested] 11+ messages in thread* [Bug hurd/1254] getpeername(fd,NULL,&len) crashes even if len==0
[not found] <20050826230859.1254.tschwinge@gnu.org>
` (9 preceding siblings ...)
2005-10-23 1:01 ` roland at gnu dot org
@ 2005-10-23 22:11 ` samuel dot thibault at ens-lyon dot org
10 siblings, 0 replies; 11+ messages in thread
From: samuel dot thibault at ens-lyon dot org @ 2005-10-23 22:11 UTC (permalink / raw)
To: glibc-bugs
------- Additional Comments From samuel dot thibault at ens-lyon dot org 2005-10-23 19:15 -------
Seems good, thanks!
--
What |Removed |Added
----------------------------------------------------------------------------
Status|WAITING |RESOLVED
Resolution| |FIXED
http://sourceware.org/bugzilla/show_bug.cgi?id=1254
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
^ permalink raw reply [flat|nested] 11+ messages in thread