From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <glibc-bugs-return-3659-listarch-glibc-bugs=sources.redhat.com@sourceware.org>
Received: (qmail 4812 invoked by alias); 25 Nov 2005 12:49:39 -0000
Received: (qmail 4802 invoked by uid 48); 25 Nov 2005 12:49:35 -0000
Date: Fri, 25 Nov 2005 12:49:00 -0000
From: "heiko dot nardmann at secunet dot com" <sourceware-bugzilla@sourceware.org>
To: glibc-bugs@sources.redhat.com
Message-ID: <20051125124935.1925.heiko.nardmann@secunet.com>
Reply-To: sourceware-bugzilla@sourceware.org
Subject: [Bug libc/1925] New: parameter check in yp_order() in nis/ypclnt
X-Bugzilla-Reason: CC
Mailing-List: contact glibc-bugs-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:glibc-bugs-subscribe@sourceware.org>
List-Post: <mailto:glibc-bugs@sourceware.org>
List-Help: <mailto:glibc-bugs-help@sourceware.org>, <http://sourceware.org/lists.html#faqs>
Sender: glibc-bugs-owner@sourceware.org
X-SW-Source: 2005-11/txt/msg00122.txt.bz2
List-Id: <glibc-bugs.sourceware.org>

The yp_order() function starts with the following check: 
 
  if (indomain == NULL || indomain[0] == '\0' || 
      inmap == NULL || inmap == '\0') 
    return YPERR_BADARGS; 
 
My lint tool complains about the checking of inmap against '\0'. Shouldn't this 
line look like: 
 
  if (indomain == NULL || indomain[0] == '\0' || 
      inmap == NULL || inmap[0] == '\0') 
    return YPERR_BADARGS; 
 
The same is true for function yp_all().

-- 
           Summary: parameter check in yp_order() in nis/ypclnt
           Product: glibc
           Version: 2.3.5
            Status: NEW
          Severity: minor
          Priority: P2
         Component: libc
        AssignedTo: drepper at redhat dot com
        ReportedBy: heiko dot nardmann at secunet dot com
                CC: glibc-bugs at sources dot redhat dot com


http://sourceware.org/bugzilla/show_bug.cgi?id=1925

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.