public inbox for glibc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug libc/1939] New: int return instead of enum value in inet/getnetgrent_r.c
@ 2005-11-28 15:14 heiko dot nardmann at secunet dot com
2005-11-28 15:17 ` [Bug libc/1939] " heiko dot nardmann at secunet dot com
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: heiko dot nardmann at secunet dot com @ 2005-11-28 15:14 UTC (permalink / raw)
To: glibc-bugs
In the file inet/getnetgrent_r.c in function setup() at line 57 there is the
following block:
else if (startp == (service_user *) -1)
/* No services at all. */
return 1;
else
Now I wonder what "1" stands for; according to nss/nss.h "1" stands for
NSS_STATUS_SUCCESS. But NSS_STATUS_UNAVAIL seems to be the right thing IMHO.
At least returning an integer value instead of enum value is not clean.
--
Summary: int return instead of enum value in inet/getnetgrent_r.c
Product: glibc
Version: 2.3.5
Status: NEW
Severity: minor
Priority: P2
Component: libc
AssignedTo: drepper at redhat dot com
ReportedBy: heiko dot nardmann at secunet dot com
CC: glibc-bugs at sources dot redhat dot com
http://sourceware.org/bugzilla/show_bug.cgi?id=1939
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
^ permalink raw reply [flat|nested] 6+ messages in thread* [Bug libc/1939] int return instead of enum value in inet/getnetgrent_r.c
2005-11-28 15:14 [Bug libc/1939] New: int return instead of enum value in inet/getnetgrent_r.c heiko dot nardmann at secunet dot com
@ 2005-11-28 15:17 ` heiko dot nardmann at secunet dot com
2005-11-28 15:23 ` heiko dot nardmann at secunet dot com
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: heiko dot nardmann at secunet dot com @ 2005-11-28 15:17 UTC (permalink / raw)
To: glibc-bugs
------- Additional Comments From heiko dot nardmann at secunet dot com 2005-11-28 15:16 -------
The type of no_more in this function should be enum, too.
--
http://sourceware.org/bugzilla/show_bug.cgi?id=1939
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
^ permalink raw reply [flat|nested] 6+ messages in thread* [Bug libc/1939] int return instead of enum value in inet/getnetgrent_r.c
2005-11-28 15:14 [Bug libc/1939] New: int return instead of enum value in inet/getnetgrent_r.c heiko dot nardmann at secunet dot com
2005-11-28 15:17 ` [Bug libc/1939] " heiko dot nardmann at secunet dot com
@ 2005-11-28 15:23 ` heiko dot nardmann at secunet dot com
2005-12-16 11:13 ` kukuk at suse dot de
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: heiko dot nardmann at secunet dot com @ 2005-11-28 15:23 UTC (permalink / raw)
To: glibc-bugs
------- Additional Comments From heiko dot nardmann at secunet dot com 2005-11-28 15:23 -------
Is it possible to change the return value of DB_LOOKUP_FCT in
nss/XXX-lookup.c
to enum nss_status? Currently it is int.
--
http://sourceware.org/bugzilla/show_bug.cgi?id=1939
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
^ permalink raw reply [flat|nested] 6+ messages in thread* [Bug libc/1939] int return instead of enum value in inet/getnetgrent_r.c
2005-11-28 15:14 [Bug libc/1939] New: int return instead of enum value in inet/getnetgrent_r.c heiko dot nardmann at secunet dot com
2005-11-28 15:17 ` [Bug libc/1939] " heiko dot nardmann at secunet dot com
2005-11-28 15:23 ` heiko dot nardmann at secunet dot com
@ 2005-12-16 11:13 ` kukuk at suse dot de
2005-12-16 11:14 ` kukuk at suse dot de
2005-12-16 11:14 ` kukuk at suse dot de
4 siblings, 0 replies; 6+ messages in thread
From: kukuk at suse dot de @ 2005-12-16 11:13 UTC (permalink / raw)
To: glibc-bugs
------- Additional Comments From kukuk at suse dot de 2005-12-16 11:13 -------
(In reply to comment #0)
> Now I wonder what "1" stands for; according to nss/nss.h "1" stands for
> NSS_STATUS_SUCCESS. But NSS_STATUS_UNAVAIL seems to be the right thing IMHO.
> At least returning an integer value instead of enum value is not clean.
This has nothing to do with nss.h and the meaning is clearly defined in the
comment for this function.
--
http://sourceware.org/bugzilla/show_bug.cgi?id=1939
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug libc/1939] int return instead of enum value in inet/getnetgrent_r.c
2005-11-28 15:14 [Bug libc/1939] New: int return instead of enum value in inet/getnetgrent_r.c heiko dot nardmann at secunet dot com
` (2 preceding siblings ...)
2005-12-16 11:13 ` kukuk at suse dot de
@ 2005-12-16 11:14 ` kukuk at suse dot de
2005-12-16 11:14 ` kukuk at suse dot de
4 siblings, 0 replies; 6+ messages in thread
From: kukuk at suse dot de @ 2005-12-16 11:14 UTC (permalink / raw)
To: glibc-bugs
------- Additional Comments From kukuk at suse dot de 2005-12-16 11:14 -------
(In reply to comment #2)
> Is it possible to change the return value of DB_LOOKUP_FCT in
> nss/XXX-lookup.c
> to enum nss_status? Currently it is int.
This does not make sense at all. This function does not return
nss_status values, it returns if there is a service or not.
--
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |INVALID
http://sourceware.org/bugzilla/show_bug.cgi?id=1939
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
^ permalink raw reply [flat|nested] 6+ messages in thread* [Bug libc/1939] int return instead of enum value in inet/getnetgrent_r.c
2005-11-28 15:14 [Bug libc/1939] New: int return instead of enum value in inet/getnetgrent_r.c heiko dot nardmann at secunet dot com
` (3 preceding siblings ...)
2005-12-16 11:14 ` kukuk at suse dot de
@ 2005-12-16 11:14 ` kukuk at suse dot de
4 siblings, 0 replies; 6+ messages in thread
From: kukuk at suse dot de @ 2005-12-16 11:14 UTC (permalink / raw)
To: glibc-bugs
--
What |Removed |Added
----------------------------------------------------------------------------
CC| |kukuk at suse dot de
http://sourceware.org/bugzilla/show_bug.cgi?id=1939
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2005-12-16 11:14 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-11-28 15:14 [Bug libc/1939] New: int return instead of enum value in inet/getnetgrent_r.c heiko dot nardmann at secunet dot com
2005-11-28 15:17 ` [Bug libc/1939] " heiko dot nardmann at secunet dot com
2005-11-28 15:23 ` heiko dot nardmann at secunet dot com
2005-12-16 11:13 ` kukuk at suse dot de
2005-12-16 11:14 ` kukuk at suse dot de
2005-12-16 11:14 ` kukuk at suse dot de
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).