[Bug libc/2163] New: ioctl() crashes if error value is returned

[Bug libc/2163] New: ioctl() crashes if error value is returned

[christoph dot stueckjuergen at siemens dot com]

The following code causes SIGSEGV if the ioctl returns an error value:

void test()
{
       int fd = open("/dev/ttyXR3", O_RDWR);
       char dummy[512];
       if (ioctl(fd, TCSETSW, dummy) < 0) {
               printf("hello\n");
       }
}

The problem is that the pointer to the global offset table (gp) is modified and
not correctly restored in the glibc implementation for MIPS64.

-- 
           Summary: ioctl() crashes if error value is returned
           Product: glibc
           Version: 2.3.5
            Status: NEW
          Severity: normal
          Priority: P2
         Component: libc
        AssignedTo: drepper at redhat dot com
        ReportedBy: christoph dot stueckjuergen at siemens dot com
                CC: glibc-bugs at sources dot redhat dot com
 GCC build triplet: x86_64-linux-gnu
  GCC host triplet: x86_64-linux-gnu
GCC target triplet: mips64-linux-gnu


http://sourceware.org/bugzilla/show_bug.cgi?id=2163

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug libc/2163] ioctl() crashes if error value is returned

[christoph dot stueckjuergen at siemens dot com]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
   GCC host triplet|x86_64-linux-gnu            |mips64-linux-gnu


http://sourceware.org/bugzilla/show_bug.cgi?id=2163

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug libc/2163] ioctl() crashes if error value is returned

[christoph dot stueckjuergen at siemens dot com]

------- Additional Comments From christoph dot stueckjuergen at siemens dot com  2006-01-17 11:26 -------
Created an attachment (id=836)
 --> (http://sourceware.org/bugzilla/attachment.cgi?id=836&action=view)
proposed patch for fixing the ioctl() problem for MIPS64 glibc


-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=2163

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug libc/2163] ioctl() crashes if error value is returned

[aj at suse dot de]

------- Additional Comments From aj at suse dot de  2006-01-17 13:10 -------
The current code in glibc CVS has:

L(error):
	SETUP_GP64 (a0, __ioctl)
	PTR_LA t9, __syscall_error
	RESTORE_GP64
	jr t9

I'll check this later...

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|drepper at redhat dot com   |aj at suse dot de
             Status|NEW                         |ASSIGNED


http://sourceware.org/bugzilla/show_bug.cgi?id=2163

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug libc/2163] ioctl() crashes if error value is returned

[christoph dot stueckjuergen at siemens dot com]

------- Additional Comments From christoph dot stueckjuergen at siemens dot com  2006-01-17 13:40 -------
Subject: Re:  ioctl() crashes if error value is returned

I see...  
 
RESTORE_GP64 is #defined as .cpreturn. So it looks like it's already fixed in 
the current version. 


-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=2163

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug libc/2163] ioctl() crashes if error value is returned

[gernot dot hillier at siemens dot com]

------- Additional Comments From gernot dot hillier at siemens dot com  2006-01-31 16:26 -------
See also bug 933. 

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gernot dot hillier at
                   |                            |siemens dot com


http://sourceware.org/bugzilla/show_bug.cgi?id=2163

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug libc/2163] ioctl() crashes if error value is returned

[aj at suse dot de]

------- Additional Comments From aj at suse dot de  2006-02-11 16:01 -------
Ok, let's close it as fixed for 2.4.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://sourceware.org/bugzilla/show_bug.cgi?id=2163

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.