public inbox for glibc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug libc/2798] New: localedata/locales % Charset comment string fixes
@ 2006-06-19 13:24 leonard-glibc-bugs at ottolander dot nl
  2006-06-19 13:25 ` [Bug libc/2798] " leonard-glibc-bugs at ottolander dot nl
                   ` (6 more replies)
  0 siblings, 7 replies; 8+ messages in thread
From: leonard-glibc-bugs at ottolander dot nl @ 2006-06-19 13:24 UTC (permalink / raw)
  To: glibc-bugs

I came across a couple of inconsistencies in the %Charset strings in the locale
files in localedata/locales.

Changes:
Replaced %Charsets string with %Charset
Replaced wrongly spelled or unknown charsets

I'll attach a patch.

-- 
           Summary: localedata/locales % Charset comment string fixes
           Product: glibc
           Version: 2.3.6
            Status: NEW
          Severity: minor
          Priority: P2
         Component: libc
        AssignedTo: drepper at redhat dot com
        ReportedBy: leonard-glibc-bugs at ottolander dot nl
                CC: glibc-bugs at sources dot redhat dot com
 GCC build triplet: n/r
  GCC host triplet: n/r
GCC target triplet: n/r


http://sourceware.org/bugzilla/show_bug.cgi?id=2798

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [Bug libc/2798] localedata/locales % Charset comment string fixes
  2006-06-19 13:24 [Bug libc/2798] New: localedata/locales % Charset comment string fixes leonard-glibc-bugs at ottolander dot nl
@ 2006-06-19 13:25 ` leonard-glibc-bugs at ottolander dot nl
  2006-06-21 14:13 ` leonard-glibc-bugs at ottolander dot nl
                   ` (5 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: leonard-glibc-bugs at ottolander dot nl @ 2006-06-19 13:25 UTC (permalink / raw)
  To: glibc-bugs


------- Additional Comments From leonard-glibc-bugs at ottolander dot nl  2006-06-19 13:25 -------
Created an attachment (id=1101)
 --> (http://sourceware.org/bugzilla/attachment.cgi?id=1101&action=view)
Fix inconsistencies in %Charset comments


-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=2798

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [Bug libc/2798] localedata/locales % Charset comment string fixes
  2006-06-19 13:24 [Bug libc/2798] New: localedata/locales % Charset comment string fixes leonard-glibc-bugs at ottolander dot nl
  2006-06-19 13:25 ` [Bug libc/2798] " leonard-glibc-bugs at ottolander dot nl
@ 2006-06-21 14:13 ` leonard-glibc-bugs at ottolander dot nl
  2006-06-21 14:16 ` leonard-glibc-bugs at ottolander dot nl
                   ` (4 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: leonard-glibc-bugs at ottolander dot nl @ 2006-06-21 14:13 UTC (permalink / raw)
  To: glibc-bugs


------- Additional Comments From leonard-glibc-bugs at ottolander dot nl  2006-06-21 14:13 -------
Created an attachment (id=1106)
 --> (http://sourceware.org/bugzilla/attachment.cgi?id=1106&action=view)
Improved version to reflect decision in bug 2799


-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
Attachment #1101 is|0                           |1
           obsolete|                            |


http://sourceware.org/bugzilla/show_bug.cgi?id=2798

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [Bug libc/2798] localedata/locales % Charset comment string fixes
  2006-06-19 13:24 [Bug libc/2798] New: localedata/locales % Charset comment string fixes leonard-glibc-bugs at ottolander dot nl
  2006-06-19 13:25 ` [Bug libc/2798] " leonard-glibc-bugs at ottolander dot nl
  2006-06-21 14:13 ` leonard-glibc-bugs at ottolander dot nl
@ 2006-06-21 14:16 ` leonard-glibc-bugs at ottolander dot nl
  2006-08-13  8:31 ` drepper at redhat dot com
                   ` (3 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: leonard-glibc-bugs at ottolander dot nl @ 2006-06-21 14:16 UTC (permalink / raw)
  To: glibc-bugs


------- Additional Comments From leonard-glibc-bugs at ottolander dot nl  2006-06-21 14:16 -------
Created an attachment (id=1107)
 --> (http://sourceware.org/bugzilla/attachment.cgi?id=1107&action=view)
Missed two underscores in last patch


-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
Attachment #1106 is|0                           |1
           obsolete|                            |


http://sourceware.org/bugzilla/show_bug.cgi?id=2798

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [Bug libc/2798] localedata/locales % Charset comment string fixes
  2006-06-19 13:24 [Bug libc/2798] New: localedata/locales % Charset comment string fixes leonard-glibc-bugs at ottolander dot nl
                   ` (2 preceding siblings ...)
  2006-06-21 14:16 ` leonard-glibc-bugs at ottolander dot nl
@ 2006-08-13  8:31 ` drepper at redhat dot com
  2006-08-13 10:24 ` leonard-glibc-bugs at ottolander dot nl
                   ` (2 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: drepper at redhat dot com @ 2006-08-13  8:31 UTC (permalink / raw)
  To: glibc-bugs


------- Additional Comments From drepper at redhat dot com  2006-08-13 08:31 -------
You cannot just change the encodings specified in the file.  The locale author
might have a reason to name an encoding we don't support.  I have no problems
with fixing the spelling but that's it, no other change should be made.  There
is no reason to duplicate the information contained in the SUPPORTED file. 
Update the patch and I'll apply it.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |WAITING


http://sourceware.org/bugzilla/show_bug.cgi?id=2798

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [Bug libc/2798] localedata/locales % Charset comment string fixes
  2006-06-19 13:24 [Bug libc/2798] New: localedata/locales % Charset comment string fixes leonard-glibc-bugs at ottolander dot nl
                   ` (3 preceding siblings ...)
  2006-08-13  8:31 ` drepper at redhat dot com
@ 2006-08-13 10:24 ` leonard-glibc-bugs at ottolander dot nl
  2006-08-24  6:57 ` drepper at redhat dot com
  2007-02-17 19:10 ` drepper at redhat dot com
  6 siblings, 0 replies; 8+ messages in thread
From: leonard-glibc-bugs at ottolander dot nl @ 2006-08-13 10:24 UTC (permalink / raw)
  To: glibc-bugs


------- Additional Comments From leonard-glibc-bugs at ottolander dot nl  2006-08-13 10:23 -------
I don't mind fixing this patch, but I'm unsure as to which hunks would be
allowable and which aren't.

F.e. is
-% Charset: CP1251
+% Charset: CP1251, UTF-8
for be_BY acceptable? (UTF-8 being in use for this locale)

How about
-% Charset: BALTIC
+% Charset: ISO-8859-13
for lt_LT? I would say "no" according to your remark, but what charset is "BALTIC"?

How about the addition
+% Charset: UTF-8
for bg_BG which doesn't have a charset mentioned in the comments yet?

Maybe it's just easiest if you handpick acceptable hunks yourself. That should
be much less work than having to go back and forth a couple of times.


-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|WAITING                     |NEW


http://sourceware.org/bugzilla/show_bug.cgi?id=2798

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [Bug libc/2798] localedata/locales % Charset comment string fixes
  2006-06-19 13:24 [Bug libc/2798] New: localedata/locales % Charset comment string fixes leonard-glibc-bugs at ottolander dot nl
                   ` (4 preceding siblings ...)
  2006-08-13 10:24 ` leonard-glibc-bugs at ottolander dot nl
@ 2006-08-24  6:57 ` drepper at redhat dot com
  2007-02-17 19:10 ` drepper at redhat dot com
  6 siblings, 0 replies; 8+ messages in thread
From: drepper at redhat dot com @ 2006-08-24  6:57 UTC (permalink / raw)
  To: glibc-bugs


------- Additional Comments From drepper at redhat dot com  2006-08-24 06:57 -------
> -% Charset: CP1251
> +% Charset: CP1251, UTF-8

Unnecessary, everything can use UTF-8.


> -% Charset: BALTIC
> +% Charset: ISO-8859-13
> for lt_LT? I would say "no" according to your remark, but what charset is
> "BALTIC"?

No, because this is what the author specified.



> How about the addition
> +% Charset: UTF-8
> for bg_BG which doesn't have a charset mentioned in the comments yet?

Not needed.  UTF-8 is universal.


-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |WAITING


http://sourceware.org/bugzilla/show_bug.cgi?id=2798

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [Bug libc/2798] localedata/locales % Charset comment string fixes
  2006-06-19 13:24 [Bug libc/2798] New: localedata/locales % Charset comment string fixes leonard-glibc-bugs at ottolander dot nl
                   ` (5 preceding siblings ...)
  2006-08-24  6:57 ` drepper at redhat dot com
@ 2007-02-17 19:10 ` drepper at redhat dot com
  6 siblings, 0 replies; 8+ messages in thread
From: drepper at redhat dot com @ 2007-02-17 19:10 UTC (permalink / raw)
  To: glibc-bugs


------- Additional Comments From drepper at redhat dot com  2007-02-17 19:10 -------
No reply in 6 months.  Closing.  Reopen in case you have a fixed patch.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|WAITING                     |RESOLVED
         Resolution|                            |WORKSFORME


http://sourceware.org/bugzilla/show_bug.cgi?id=2798

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.


^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2007-02-17 19:10 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-06-19 13:24 [Bug libc/2798] New: localedata/locales % Charset comment string fixes leonard-glibc-bugs at ottolander dot nl
2006-06-19 13:25 ` [Bug libc/2798] " leonard-glibc-bugs at ottolander dot nl
2006-06-21 14:13 ` leonard-glibc-bugs at ottolander dot nl
2006-06-21 14:16 ` leonard-glibc-bugs at ottolander dot nl
2006-08-13  8:31 ` drepper at redhat dot com
2006-08-13 10:24 ` leonard-glibc-bugs at ottolander dot nl
2006-08-24  6:57 ` drepper at redhat dot com
2007-02-17 19:10 ` drepper at redhat dot com

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).