[Bug libc/2914] New: gethostid don't check if file exist before tryng to use it

[Bug libc/2914] New: gethostid don't check if file exist before tryng to use it

[julien dot dumont at certess dot com]

using gethostid() function provide by glibc trying to open twice a file which
don't exist. 

strace output concerning this function. 

open("/etc/hostid", O_RDONLY|O_LARGEFILE) = -1 ENOENT (No such file or directory)
open("/etc/hostid", O_RDONLY|O_LARGEFILE) = -1 ENOENT (No such file or directory)

-- 
           Summary: gethostid don't check if file exist before tryng to use
                    it
           Product: glibc
           Version: 2.3.4
            Status: NEW
          Severity: enhancement
          Priority: P3
         Component: libc
        AssignedTo: drepper at redhat dot com
        ReportedBy: julien dot dumont at certess dot com
                CC: glibc-bugs at sources dot redhat dot com
  GCC host triplet: i686


http://sourceware.org/bugzilla/show_bug.cgi?id=2914

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug libc/2914] gethostid don't check if file exist before tryng to use it

[julien dot dumont at certess dot com]

------- Additional Comments From julien dot dumont at certess dot com  2006-07-13 12:44 -------
Created an attachment (id=1158)
 --> (http://sourceware.org/bugzilla/attachment.cgi?id=1158&action=view)
sample for reproduct

hostid.c is an example for reproduct.

-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=2914

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug libc/2914] gethostid don't check if file exist before tryng to use it

[julien dot dumont at certess dot com]

------- Additional Comments From julien dot dumont at certess dot com  2006-07-13 12:46 -------
Created an attachment (id=1159)
 --> (http://sourceware.org/bugzilla/attachment.cgi?id=1159&action=view)
patch for fedora core 3 SRPMS glibc-2.3.3-74.src.rpm 

patch for fedora core 3 SRPMS glibc-2.3.3-74.src.rpm 

-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=2914

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug libc/2914] gethostid don't check if file exist before tryng to use it

[julien dot dumont at certess dot com]

------- Additional Comments From julien dot dumont at certess dot com  2006-07-13 12:48 -------
Created an attachment (id=1160)
 --> (http://sourceware.org/bugzilla/attachment.cgi?id=1160&action=view)
patch for generic GNU glibc 2.3

patch for generic GNU glibc 2.3

-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=2914

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug libc/2914] gethostid don't check if file exist before tryng to use it

[julien dot dumont at certess dot com]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|2.3.4                       |2.3.3


http://sourceware.org/bugzilla/show_bug.cgi?id=2914

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug libc/2914] gethostid don't check if file exist before tryng to use it

[julien dot dumont at certess dot com]

------- Additional Comments From julien dot dumont at certess dot com  2006-07-13 12:50 -------
This exist also on glibc 2.4 and the patch is the same. ( use stat )


-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=2914

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug libc/2914] gethostid don't check if file exist before tryng to use it

[drepper at redhat dot com]

------- Additional Comments From drepper at redhat dot com  2006-08-03 08:51 -------
I've changed this is CVS.  The patch isn't OK.  There is no need for the stat
because a) it's not really much faster than the open and b) if somebody uses
gethostid there better be such a file.  The real problem was that the patch
introducing the OLD_HOSTIDFILE macro contained  abug.  This is now fixed.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED


http://sourceware.org/bugzilla/show_bug.cgi?id=2914

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug libc/2914] gethostid don't check if file exist before tryng to use it

[julien dot dumont at certess dot com]

------- Additional Comments From julien dot dumont at certess dot com  2006-08-03 20:15 -------
Thanks for this ;)

I'm agree with you about open and stat and their performance on local filesystem.
But It seems thant it's not the case over Network filesystem or Virtual filesystem.

Sure isn't a good idea to have /etc/ over VFS or NFS, but in this case it seems
than using 'open' have mores 'impact' than using only stat. Performance be
better and we don't have problem with concurent remote access.
 

But in fact is it true or it's just my feelings ?

Julien

-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=2914

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.