[Bug libc/2926] New: assert macro contains unreachable code

[Bug libc/2926] New: assert macro contains unreachable code

[Jerry dot James at usu dot edu]

When compiling with gcc and the -Wunreachable-code flag, gcc warns about every
use of the assert macro from <assert.h>.  This was reported as a gcc bug (see
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22414), but the gcc team declared it
to be a glibc bug.  Indeed, moving __ASSERT_VOID_CAST inward to apply to the two
instances of 0 in assert and assert_perror leaves the assertions working
correctly and eliminates the warnings for me.  I don't see a place to include a
patch on this page, so I'll submit the bug and hope I can attach a patch later.

-- 
           Summary: assert macro contains unreachable code
           Product: glibc
           Version: 2.4
            Status: NEW
          Severity: minor
          Priority: P3
         Component: libc
        AssignedTo: drepper at redhat dot com
        ReportedBy: Jerry dot James at usu dot edu
                CC: glibc-bugs at sources dot redhat dot com


http://sourceware.org/bugzilla/show_bug.cgi?id=2926

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug libc/2926] assert macro contains unreachable code

[Jerry dot James at usu dot edu]

------- Additional Comments From Jerry dot James at usu dot edu  2006-07-14 19:56 -------
Created an attachment (id=1163)
 --> (http://sourceware.org/bugzilla/attachment.cgi?id=1163&action=view)
Proposed patch to assert.h


-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=2926

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug libc/2926] assert macro contains unreachable code

[drepper at redhat dot com]

------- Additional Comments From drepper at redhat dot com  2006-08-03 08:30 -------
Changed in CVS.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED


http://sourceware.org/bugzilla/show_bug.cgi?id=2926

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug libc/2926] assert macro contains unreachable code

[roche+kml2 at exalead dot com]

------- Additional Comments From roche+kml2 at exalead dot com  2007-04-20 08:14 -------
This patch now raises a new gcc warning when compiling with -W and -pedantic for
each assert() with a condition true at compile time.

The following code snippet demonstrates the isssue:

#include <assert.h>
void foo(void) { assert(sizeof(char) == 1); }


-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |


http://sourceware.org/bugzilla/show_bug.cgi?id=2926

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug libc/2926] assert macro contains unreachable code

[drepper at redhat dot com]

------- Additional Comments From drepper at redhat dot com  2007-05-15 02:55 -------
I see no problem, it works fine for me.

-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=2926

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug libc/2926] assert macro contains unreachable code

[roche+kml2 at exalead dot com]

------- Additional Comments From roche+kml2 at exalead dot com  2007-06-01 13:33 -------
The warning is only raised with GCC 3.3 (3.3.4), not GCC 4.1 (4.1.1):

$ gcc-3.3.4 -c test.c -Wall -pedantic
1.c: In function `foo':
1.c:2: warning: statement with no effect

$ gcc-4.1.1 -c 1.c -Wall -pedantic
(no warnings)



-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=2926

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug libc/2926] assert macro contains unreachable code

[aj at suse dot de]

------- Additional Comments From aj at suse dot de  2007-06-16 17:27 -------
(In reply to comment #5)
> The warning is only raised with GCC 3.3 (3.3.4), not GCC 4.1 (4.1.1):

In that case, let's close the bug as fixed since it's working with current GCC.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|                            |FIXED


http://sourceware.org/bugzilla/show_bug.cgi?id=2926

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.