public inbox for glibc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug libc/3369] New: RFC3484 Rule 7 sorting inconsistent
@ 2006-10-16 12:41 rdenis at simphalempin dot com
  2006-10-16 15:20 ` [Bug libc/3369] " drepper at redhat dot com
  2007-01-12 15:08 ` cvs-commit at gcc dot gnu dot org
  0 siblings, 2 replies; 3+ messages in thread
From: rdenis at simphalempin dot com @ 2006-10-16 12:41 UTC (permalink / raw)
  To: glibc-bugs

In file libc/sysdeps/posix/getaddrinfo.c (rev 1.107), in function rfc3484_sort,
implementation of "Rule 7" seems to be a logical no-op.

Both ifs in the following excerpt are always false, since the conditions are
essentially "a1 is temporary and a1 is not temporary":

      if (!(a1->source_addr_flags & in6ai_temporary)
          && (a1->source_addr_flags & in6ai_temporary))
        return -1;
      if ((a1->source_addr_flags & in6ai_temporary)
          && !(a1->source_addr_flags & in6ai_temporary))
        return -1;

Probably a2 should be involved somewhere.

-- 
           Summary: RFC3484 Rule 7 sorting inconsistent
           Product: glibc
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: libc
        AssignedTo: drepper at redhat dot com
        ReportedBy: rdenis at simphalempin dot com
                CC: glibc-bugs at sources dot redhat dot com
 GCC build triplet: N/A
  GCC host triplet: N/A
GCC target triplet: N/A


http://sourceware.org/bugzilla/show_bug.cgi?id=3369

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Bug libc/3369] RFC3484 Rule 7 sorting inconsistent
  2006-10-16 12:41 [Bug libc/3369] New: RFC3484 Rule 7 sorting inconsistent rdenis at simphalempin dot com
@ 2006-10-16 15:20 ` drepper at redhat dot com
  2007-01-12 15:08 ` cvs-commit at gcc dot gnu dot org
  1 sibling, 0 replies; 3+ messages in thread
From: drepper at redhat dot com @ 2006-10-16 15:20 UTC (permalink / raw)
  To: glibc-bugs


------- Additional Comments From drepper at redhat dot com  2006-10-16 15:19 -------
Fixed in cvs.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED


http://sourceware.org/bugzilla/show_bug.cgi?id=3369

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Bug libc/3369] RFC3484 Rule 7 sorting inconsistent
  2006-10-16 12:41 [Bug libc/3369] New: RFC3484 Rule 7 sorting inconsistent rdenis at simphalempin dot com
  2006-10-16 15:20 ` [Bug libc/3369] " drepper at redhat dot com
@ 2007-01-12 15:08 ` cvs-commit at gcc dot gnu dot org
  1 sibling, 0 replies; 3+ messages in thread
From: cvs-commit at gcc dot gnu dot org @ 2007-01-12 15:08 UTC (permalink / raw)
  To: glibc-bugs


------- Additional Comments From cvs-commit at gcc dot gnu dot org  2007-01-12 15:07 -------
Subject: Bug 3369

CVSROOT:	/cvs/glibc
Module name:	libc
Branch: 	glibc-2_5-branch
Changes by:	jakub@sourceware.org	2007-01-12 15:07:33

Modified files:
	.              : ChangeLog 
	sysdeps/posix  : getaddrinfo.c 

Log message:
	[BZ #3369]
	* sysdeps/posix/getaddrinfo.c (rfc3484_sort): Fix typos in rules 4
	and 7.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/libc/ChangeLog.diff?cvsroot=glibc&only_with_tag=glibc-2_5-branch&r1=1.10362.2.5&r2=1.10362.2.6
http://sourceware.org/cgi-bin/cvsweb.cgi/libc/sysdeps/posix/getaddrinfo.c.diff?cvsroot=glibc&only_with_tag=glibc-2_5-branch&r1=1.107&r2=1.107.2.1



-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=3369

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2007-01-12 15:08 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-10-16 12:41 [Bug libc/3369] New: RFC3484 Rule 7 sorting inconsistent rdenis at simphalempin dot com
2006-10-16 15:20 ` [Bug libc/3369] " drepper at redhat dot com
2007-01-12 15:08 ` cvs-commit at gcc dot gnu dot org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).