public inbox for glibc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "drepper at redhat dot com" <sourceware-bugzilla@sourceware.org>
To: glibc-bugs@sources.redhat.com
Subject: [Bug math/3451] dangerous inlining of floor and ceil on i386.
Date: Fri, 10 Nov 2006 17:05:00 -0000	[thread overview]
Message-ID: <20061110170537.11989.qmail@sourceware.org> (raw)
In-Reply-To: <20061102224237.3451.David.Warme@Group-W-Inc.com>


------- Additional Comments From drepper at redhat dot com  2006-11-10 17:05 -------
The patch is not sufficient.  If the compiler can pull something in between the
fldcw instructions then code which changes the CW might be pulled between the
fnstcw and first fldcw.  I've checked in a complete patch.

And next time, don't use this unreadable context diff format.  Alsways use -u.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED


http://sourceware.org/bugzilla/show_bug.cgi?id=3451

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.


  parent reply	other threads:[~2006-11-10 17:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-02 22:42 [Bug math/3451] New: " David dot Warme at Group-W-Inc dot com
2006-11-02 22:45 ` [Bug math/3451] " David dot Warme at Group-W-Inc dot com
2006-11-10 17:05 ` drepper at redhat dot com [this message]
2007-01-12 15:31 ` cvs-commit at gcc dot gnu dot org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061110170537.11989.qmail@sourceware.org \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=glibc-bugs@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).