public inbox for glibc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug libc/4026] New: Missing include <time.h> in clock_settime.c
@ 2007-02-12 1:41 aurelien at aurel32 dot net
2007-02-15 13:13 ` [Bug ports/4026] " jakub at redhat dot com
0 siblings, 1 reply; 4+ messages in thread
From: aurelien at aurel32 dot net @ 2007-02-12 1:41 UTC (permalink / raw)
To: glibc-bugs
sysdeps/unix/sysv/linux/clock_settime.c is using the type clock_id which is
defined in time.h. However it does not includes this header.
The patch below adds the include line, as it is already done in all clock_*.c
file of this directory.
--- sysdeps/unix/sysv/linux/clock_settime.c 2007-02-11 18:53:19.000000000
+0100
+++ sysdeps/unix/sysv/linux/clock_settime.c 2007-02-11 18:53:31.000000000
+0100
@@ -18,6 +18,7 @@
#include <errno.h>
#include <sysdep.h>
+#include <time.h>
#include "kernel-posix-cpu-timers.h"
#include <kernel-features.h>
--
Summary: Missing include <time.h> in clock_settime.c
Product: glibc
Version: unspecified
Status: NEW
Severity: normal
Priority: P2
Component: libc
AssignedTo: drepper at redhat dot com
ReportedBy: aurelien at aurel32 dot net
CC: glibc-bugs at sources dot redhat dot com
GCC build triplet: m68k-unknown-linux-gnu
GCC host triplet: m68k-unknown-linux-gnu
GCC target triplet: m68k-unknown-linux-gnu
http://sourceware.org/bugzilla/show_bug.cgi?id=4026
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Bug ports/4026] Missing include <time.h> in clock_settime.c
2007-02-12 1:41 [Bug libc/4026] New: Missing include <time.h> in clock_settime.c aurelien at aurel32 dot net
@ 2007-02-15 13:13 ` jakub at redhat dot com
0 siblings, 0 replies; 4+ messages in thread
From: jakub at redhat dot com @ 2007-02-15 13:13 UTC (permalink / raw)
To: glibc-bugs
------- Additional Comments From jakub at redhat dot com 2007-02-15 13:13 -------
If clock_settime.c doesn't compile on m68k, then it should be fixed to follow
other architectures. In this case, errno.h included by clock_settime.c
and include/errno.h includes tls.h which is expected to include stdlib.h
and stdlib.h defines clockid_t as well.
--
What |Removed |Added
----------------------------------------------------------------------------
AssignedTo|drepper at redhat dot com |roland at gnu dot org
Component|libc |ports
http://sourceware.org/bugzilla/show_bug.cgi?id=4026
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Bug ports/4026] Missing include <time.h> in clock_settime.c
[not found] <bug-4026-131@http.sourceware.org/bugzilla/>
2012-02-15 20:56 ` jsm28 at gcc dot gnu.org
@ 2012-02-17 16:49 ` aurelien at aurel32 dot net
1 sibling, 0 replies; 4+ messages in thread
From: aurelien at aurel32 dot net @ 2012-02-17 16:49 UTC (permalink / raw)
To: glibc-bugs
http://sourceware.org/bugzilla/show_bug.cgi?id=4026
Aurelien Jarno <aurelien at aurel32 dot net> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
--- Comment #3 from Aurelien Jarno <aurelien at aurel32 dot net> 2012-02-17 16:49:37 UTC ---
Fixed in commit 8dee4833c5b6d3c2ad506b5c7fdc548504386f96
--
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Bug ports/4026] Missing include <time.h> in clock_settime.c
[not found] <bug-4026-131@http.sourceware.org/bugzilla/>
@ 2012-02-15 20:56 ` jsm28 at gcc dot gnu.org
2012-02-17 16:49 ` aurelien at aurel32 dot net
1 sibling, 0 replies; 4+ messages in thread
From: jsm28 at gcc dot gnu.org @ 2012-02-15 20:56 UTC (permalink / raw)
To: glibc-bugs
http://sourceware.org/bugzilla/show_bug.cgi?id=4026
Joseph Myers <jsm28 at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
AssignedTo|roland at gnu dot org |aurelien at aurel32 dot net
--- Comment #2 from Joseph Myers <jsm28 at gcc dot gnu.org> 2012-02-15 20:47:46 UTC ---
It was agreed in the latest discussion on libc-alpha that we *do* want this
sort of patch to make source files include headers for interfaces they use
rather than relying on long indirect include paths. So, this is OK; please
commit this patch and close this bug once your write access is set up.
(I don't think this was really an m68k issue; I think it was probably a
Linuxthreads issue and so the actual build failure would have been removed by
the addition of NPTL for m68k. But, this sort of fix still makes sense as a
cleanup.)
--
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-02-17 16:49 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-02-12 1:41 [Bug libc/4026] New: Missing include <time.h> in clock_settime.c aurelien at aurel32 dot net
2007-02-15 13:13 ` [Bug ports/4026] " jakub at redhat dot com
[not found] <bug-4026-131@http.sourceware.org/bugzilla/>
2012-02-15 20:56 ` jsm28 at gcc dot gnu.org
2012-02-17 16:49 ` aurelien at aurel32 dot net
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).