[Bug nptl/4465] pthread cancellation points missing for fdatasync and lockf in some cases

[Bug nptl/4465] pthread cancellation points missing for fdatasync and lockf in some cases

[vapier at gentoo dot org]

------- Additional Comments From vapier at gentoo dot org  2007-05-06 08:58 -------
Created an attachment (id=1755)
 --> (http://sourceware.org/bugzilla/attachment.cgi?id=1755&action=view)
glibc-fdatasync-lockf-cancellation.patch


-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=4465

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug nptl/4465] New: pthread cancellation points missing for fdatasync and lockf in some cases

[vapier at gentoo dot org]

POSIX requires fdatasync() and lockf() be pthread cancellation endpoints but it
looks like they get missed a little in glibc ...

fdatasync() is generated for Linux simply via syscalls.list as a pass through to
the kernel... the generic case in misc/fdatasync.c relies on fsync() being a
cancellation endpoint ... so here, just Linux is broken it seems

as for lockf(), this seems to be [incorrectly] done on purpose ... io/lockf.c
talks about relying on fcntl()'s cancellation endpoint when called with F_SETLKW
as that is the only case that POSIX says fcntl() should be a cancellation
endpoint ... however, POSIX does not grant this limitation to lockf() ... it
should always be a cancellation endpoint regardless of the arguments it is
called with

-- 
           Summary: pthread cancellation points missing for fdatasync and
                    lockf in some cases
           Product: glibc
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: nptl
        AssignedTo: drepper at redhat dot com
        ReportedBy: vapier at gentoo dot org
                CC: glibc-bugs at sources dot redhat dot com


http://sourceware.org/bugzilla/show_bug.cgi?id=4465

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug nptl/4465] pthread cancellation points missing for fdatasync and lockf in some cases

[drepper at redhat dot com]

------- Additional Comments From drepper at redhat dot com  2007-05-07 05:25 -------
I checked in parts of the patch.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED


http://sourceware.org/bugzilla/show_bug.cgi?id=4465

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug nptl/4465] pthread cancellation points missing for fdatasync and lockf in some cases

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2007-07-12 15:15 -------
Subject: Bug 4465

CVSROOT:	/cvs/glibc
Module name:	libc
Branch: 	glibc-2_5-branch
Changes by:	jakub@sourceware.org	2007-07-12 15:15:34

Modified files:
	nptl           : tst-cancel-wrappers.sh tst-cancel4.c 
	posix          : unistd.h 
	sysdeps/unix/sysv/linux: syscalls.list 

Log message:
	2007-05-06  Ulrich Drepper  <drepper@redhat.com>
	
	[BZ #4465]
	* posix/unistd.h: Remove __THROW from fdatasync.
	
	2007-05-06  Mike Frysinger  <vapier@gentoo.org>
	
	[BZ #4465]
	* sysdeps/unix/sysv/linux/syscalls.list (fdatasync): Add "C" to args.
	
	[BZ #4465]
	* tst-cancel-wrappers.sh: Set C["fdatasync"] to 1.
	* tst-cancel4.c (tf_fdatasync): New test.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/libc/nptl/tst-cancel-wrappers.sh.diff?cvsroot=glibc&only_with_tag=glibc-2_5-branch&r1=1.7&r2=1.7.8.1
http://sourceware.org/cgi-bin/cvsweb.cgi/libc/nptl/tst-cancel4.c.diff?cvsroot=glibc&only_with_tag=glibc-2_5-branch&r1=1.20&r2=1.20.2.1
http://sourceware.org/cgi-bin/cvsweb.cgi/libc/posix/unistd.h.diff?cvsroot=glibc&only_with_tag=glibc-2_5-branch&r1=1.147.2.1&r2=1.147.2.2
http://sourceware.org/cgi-bin/cvsweb.cgi/libc/sysdeps/unix/sysv/linux/syscalls.list.diff?cvsroot=glibc&only_with_tag=glibc-2_5-branch&r1=1.127.2.1&r2=1.127.2.2



-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=4465

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug nptl/4465] pthread cancellation points missing for fdatasync and lockf in some cases

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2007-07-12 15:20 -------
Subject: Bug 4465

CVSROOT:	/cvs/glibc
Module name:	libc
Branch: 	glibc-2_5-branch
Changes by:	jakub@sourceware.org	2007-07-12 15:19:59

Modified files:
	.              : ChangeLog 
	nptl           : ChangeLog 

Log message:
	2007-05-06  Ulrich Drepper  <drepper@redhat.com>
	
	[BZ #4465]
	* posix/unistd.h: Remove __THROW from fdatasync.
	
	2007-05-06  Mike Frysinger  <vapier@gentoo.org>
	
	[BZ #4465]
	* sysdeps/unix/sysv/linux/syscalls.list (fdatasync): Add "C" to args.
	
	[BZ #4465]
	* tst-cancel-wrappers.sh: Set C["fdatasync"] to 1.
	* tst-cancel4.c (tf_fdatasync): New test.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/libc/ChangeLog.diff?cvsroot=glibc&only_with_tag=glibc-2_5-branch&r1=1.10362.2.81&r2=1.10362.2.82
http://sourceware.org/cgi-bin/cvsweb.cgi/libc/nptl/ChangeLog.diff?cvsroot=glibc&only_with_tag=glibc-2_5-branch&r1=1.924.2.3&r2=1.924.2.4



-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=4465

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.