public inbox for glibc-bugs@sourceware.org help / color / mirror / Atom feed
From: "egmont at gmail dot com" <sourceware-bugzilla@sourceware.org> To: glibc-bugs@sources.redhat.com Subject: [Bug libc/5806] New: wrong comment in strlen() and other functions Date: Fri, 29 Feb 2008 00:37:00 -0000 [thread overview] Message-ID: <20080229003702.5806.egmont@gmail.com> (raw) strlen() and similar functions use some cool magic to determine whether any bytes of an integer is zero. This magic is explained in a long comment in all these source files. Part of this comment is: 1) Is this safe? Will it catch all the zero bytes? Suppose there is a byte with all zeros. Any carry bits propagating from its left will fall into the hole at its least significant bit and stop. [...] "propagating from its left" is wrong, it should be "propagating from its right". In glibc-2.7 there are 14 files that contain this typo. Luckily the wording and the formatting of the paragraph is exactly the same everywhere. I don't send a patch because that might easily get outdated or miss some newly added files. Rather, please do a combo of grep and sed or whatever similar tools to fix these. -- Summary: wrong comment in strlen() and other functions Product: glibc Version: unspecified Status: NEW Severity: minor Priority: P3 Component: libc AssignedTo: drepper at redhat dot com ReportedBy: egmont at gmail dot com CC: glibc-bugs at sources dot redhat dot com http://sourceware.org/bugzilla/show_bug.cgi?id=5806 ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
next reply other threads:[~2008-02-29 0:37 UTC|newest] Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top 2008-02-29 0:37 egmont at gmail dot com [this message] 2008-03-02 3:34 ` [Bug libc/5806] " carlos at codesourcery dot com 2008-03-02 8:51 ` egmont at gmail dot com 2008-03-02 15:12 ` carlos at codesourcery dot com 2009-03-15 8:50 ` drepper at redhat dot com
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20080229003702.5806.egmont@gmail.com \ --to=sourceware-bugzilla@sourceware.org \ --cc=glibc-bugs@sources.redhat.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).