public inbox for glibc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "egmont at gmail dot com" <sourceware-bugzilla@sourceware.org>
To: glibc-bugs@sources.redhat.com
Subject: [Bug libc/5806] wrong comment in strlen() and other functions
Date: Sun, 02 Mar 2008 08:51:00 -0000 [thread overview]
Message-ID: <20080302085100.527.qmail@sourceware.org> (raw)
In-Reply-To: <20080229003702.5806.egmont@gmail.com>
------- Additional Comments From egmont at gmail dot com 2008-03-02 08:50 -------
Well, the comment does match to what the code is doing now, not in strlen.c but
all the other similar files wherever this comment appears (such as strchr.c just
to mention one.)
No need to fix the comments of course, provided that you change the
implementation in all these fourteen files, not just in strlen.c; and throw out
the old version, not just put inside #if 0. If you keep the old version around,
I recommend to fix the comments because it can be done very easily, and might be
a help to anyone trying to understand that.
The algorithm you linked from bug #5807 is definitely nicer than the current
one, easier to understand, and does exact match with no false positive.
--
http://sourceware.org/bugzilla/show_bug.cgi?id=5806
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
next prev parent reply other threads:[~2008-03-02 8:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-29 0:37 [Bug libc/5806] New: " egmont at gmail dot com
2008-03-02 3:34 ` [Bug libc/5806] " carlos at codesourcery dot com
2008-03-02 8:51 ` egmont at gmail dot com [this message]
2008-03-02 15:12 ` carlos at codesourcery dot com
2009-03-15 8:50 ` drepper at redhat dot com
[not found] <bug-5806-131@http.sourceware.org/bugzilla/>
2012-05-06 18:53 ` aj at suse dot de
2014-07-02 7:00 ` fweimer at redhat dot com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080302085100.527.qmail@sourceware.org \
--to=sourceware-bugzilla@sourceware.org \
--cc=glibc-bugs@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).