From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 630 invoked by alias); 2 Mar 2008 08:51:44 -0000 Received: (qmail 528 invoked by uid 48); 2 Mar 2008 08:51:00 -0000 Date: Sun, 02 Mar 2008 08:51:00 -0000 Message-ID: <20080302085100.527.qmail@sourceware.org> From: "egmont at gmail dot com" To: glibc-bugs@sources.redhat.com In-Reply-To: <20080229003702.5806.egmont@gmail.com> References: <20080229003702.5806.egmont@gmail.com> Reply-To: sourceware-bugzilla@sourceware.org Subject: [Bug libc/5806] wrong comment in strlen() and other functions X-Bugzilla-Reason: CC Mailing-List: contact glibc-bugs-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: glibc-bugs-owner@sourceware.org X-SW-Source: 2008-03/txt/msg00004.txt.bz2 ------- Additional Comments From egmont at gmail dot com 2008-03-02 08:50 ------- Well, the comment does match to what the code is doing now, not in strlen.c but all the other similar files wherever this comment appears (such as strchr.c just to mention one.) No need to fix the comments of course, provided that you change the implementation in all these fourteen files, not just in strlen.c; and throw out the old version, not just put inside #if 0. If you keep the old version around, I recommend to fix the comments because it can be done very easily, and might be a help to anyone trying to understand that. The algorithm you linked from bug #5807 is definitely nicer than the current one, easier to understand, and does exact match with no false positive. -- http://sourceware.org/bugzilla/show_bug.cgi?id=5806 ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.