[Bug libc/5903] New: "iconv" creates unnecessary output

[Bug libc/5903] New: "iconv" creates unnecessary output

[titcouille dot mandriva at gmail dot com]

This bug concerns the "iconv" utility. It's not really a bug, but bad design. I did:

iconv --from-code==LATIN1 --to-code=UTF-8 --output=file_to_convert.xml
output_file.xml

where mistakingly I had put my original file, file_to_convert.xml, as output
file. And for source file I had specified mistakingly some output filename which
doesn't exist. So iconv displayed that "output_file.xml" doesn't exist, that it
can't read from it, but replaced my original file (file_to_convert.xml) with an
empty 0-byte file. But it's stupid that it would put an empty file (and thus
destroy all my data) when there was nothing to convert in the first place.

To sum it up, don't create an output file when there isn't an input file.

-- 
           Summary: "iconv" creates unnecessary output
           Product: glibc
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: libc
        AssignedTo: drepper at redhat dot com
        ReportedBy: titcouille dot mandriva at gmail dot com
                CC: glibc-bugs at sources dot redhat dot com


http://sourceware.org/bugzilla/show_bug.cgi?id=5903

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug libc/5903] "iconv" creates unnecessary output

[rsa at us dot ibm dot com]

------- Additional Comments From rsa at us dot ibm dot com  2008-03-10 21:17 -------
In libc/iconv/iconv_prog.c the output_file is fopen'ed prior to processing any
of the files specified on the command line.

Perhaps a lazy fopen() of the output_file can take place when an actual
fopen(argv[remaining]) succeeds.

I'll investigate.



-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|drepper at redhat dot com   |rsa at us dot ibm dot com
             Status|NEW                         |ASSIGNED


http://sourceware.org/bugzilla/show_bug.cgi?id=5903

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug libc/5903] "iconv" creates unnecessary output

[drepper at redhat dot com]

------- Additional Comments From drepper at redhat dot com  2008-03-11 20:13 -------
I checked in a patch to the trunk.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://sourceware.org/bugzilla/show_bug.cgi?id=5903

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug libc/5903] "iconv" creates unnecessary output

[fweimer at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=5903

Florian Weimer <fweimer at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |security-

-- 
You are receiving this mail because:
You are on the CC list for the bug.