[Bug libc/5807] New: strlen() not effective

[Bug libc/5807] New: strlen() not effective

[egmont at gmail dot com]

Most of the functions similar to strlen() that have to detect whether any bytes
of an integer is zero are very efficient. However, in glibc-2.7/string/strlen.c
this efficient code that's used in lots of other functions is surrounded by an
#if 0, and instead a trivial code is used which exits the loop and examines each
bytes separately if any of the bytes is within the range 129-255 or 0. That is
roughly 15/16 of all random cases in 4-bit architecture and even more in 8-bit.
Hence I think this function is hardly any more efficient than if you read one
long int and then simply examined all its bytes separately.

Is there any reason for the code that looks way more effective and is being used
in many other source files to be commented out here?

-- 
           Summary: strlen() not effective
           Product: glibc
           Version: unspecified
            Status: NEW
          Severity: minor
          Priority: P3
         Component: libc
        AssignedTo: drepper at redhat dot com
        ReportedBy: egmont at gmail dot com
                CC: glibc-bugs at sources dot redhat dot com


http://sourceware.org/bugzilla/show_bug.cgi?id=5807

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug libc/5807] strlen() not effective

[carlos at codesourcery dot com]

------- Additional Comments From carlos at codesourcery dot com  2008-03-02 03:29 -------
The math is wrong. 

It looks glibc has a broken version of Alan Mycroft's HAKMEMC postings.
See: http://www.cl.cam.ac.uk/~am21/progtricks.html

The solution is "((x - 0x01010101) & ~x & 0x80808080)", but the "& ~x" is
missing from the glibc version.

The "#if 0" was added Tue Jan 21 03:39:54 1992 UTC (16 years, 1 month ago) by
roland, and the patch looked like this:
http://sources.redhat.com/cgi-bin/cvsweb.cgi/libc/sysdeps/generic/Attic/strlen.c.diff?r1=1.1&r2=1.2&cvsroot=glibc

I can reproduce this on cvs head. The generic strlen function is horribly
inefficient.

Roland can you comment on this? 

What's the legal status of using that algorithm?

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|drepper at redhat dot com   |roland at redhat dot com
             Status|NEW                         |ASSIGNED


http://sourceware.org/bugzilla/show_bug.cgi?id=5807

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug libc/5807] strlen() not effective

[carlos at codesourcery dot com]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|                            |5806
              nThis|                            |


http://sourceware.org/bugzilla/show_bug.cgi?id=5807

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug libc/5807] strlen() not effective

[carlos at codesourcery dot com]

------- Additional Comments From carlos at codesourcery dot com  2008-03-02 15:12 -------
Note: All the string/* operations should use the corrected algorithm, and the
old comments should be removed.

-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=5807

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug libc/5807] strlen() not effective

[stas dot yakovlev at gmail dot com]

------- Additional Comments From stas dot yakovlev at gmail dot com  2008-04-17 19:55 -------
Created an attachment (id=2703)
 --> (http://sourceware.org/bugzilla/attachment.cgi?id=2703&action=view)
Alan Mycroft's hack for strlen()

Hi All.

I know that you only accept patches if
contributor signs an assignment.

But do you accept small bug fix without an
assignment, like that I attached to the bug ?

This is a fix for strlen() only
(I can do it for all other functions if you can accept
patches like this). It deletes old comments,
and adds Alan Mycroft's hack.

Stas.


-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=5807

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug libc/5807] strlen() not effective

[carlos at codesourcery dot com]

------- Additional Comments From carlos at codesourcery dot com  2008-04-22 13:03 -------
Stas,

The changes are more than trivial, you would need a copyright assignment for
glibc on file with the FSF.

-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=5807

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug libc/5807] strlen() not effective

[stas dot yakovlev at gmail dot com]

------- Additional Comments From stas dot yakovlev at gmail dot com  2008-04-23 15:48 -------
Carlos,

Thanks for reply.

-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=5807

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug libc/5807] strlen() not effective

[drepper at redhat dot com]

------- Additional Comments From drepper at redhat dot com  2009-03-15 08:50 -------
I changed the code.  Although noboy seems to use it.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://sourceware.org/bugzilla/show_bug.cgi?id=5807

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug libc/5807] strlen() not effective

[roland at gnu dot org]

http://sourceware.org/bugzilla/show_bug.cgi?id=5807

Roland McGrath <roland at gnu dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|roland at redhat dot com    |drepper.fsp at gmail dot
                   |                            |com

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[Bug libc/5807] strlen() not effective

[fweimer at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=5807

Florian Weimer <fweimer at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |security-

-- 
You are receiving this mail because:
You are on the CC list for the bug.