[Bug libc/6657] New: strptime era support broken

[Bug libc/6657] New: strptime era support broken

[pasky at suse dot cz]

strptime()'s support for eras has been broken by time/strptime_l.c:1.10 - tm is
not adjusted within the recursion anymore, but era_cnt is reset in the caller,
thus era information will never be propagated to the tm structure. I don't
understand the purpose of resetting era_cnt, so my idea for the simplest fix is
to simply get rid of that.

-- 
           Summary: strptime era support broken
           Product: glibc
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: libc
        AssignedTo: drepper at redhat dot com
        ReportedBy: pasky at suse dot cz
                CC: glibc-bugs at sources dot redhat dot com


http://sourceware.org/bugzilla/show_bug.cgi?id=6657

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug libc/6657] strptime era support broken

[pasky at suse dot cz]

------- Additional Comments From pasky at suse dot cz  2008-06-18 22:44 -------
Created an attachment (id=2785)
 --> (http://sourceware.org/bugzilla/attachment.cgi?id=2785&action=view)
proposed patch


-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=6657

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug libc/6657] strptime era support broken

[drepper at redhat dot com]

------- Additional Comments From drepper at redhat dot com  2008-06-26 00:40 -------
I see no problem with the current code.  Where is the test case which always
should accompany a bug report?

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |WAITING


http://sourceware.org/bugzilla/show_bug.cgi?id=6657

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug libc/6657] strptime era support broken

[pasky at suse dot cz]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|WAITING                     |NEW


http://sourceware.org/bugzilla/show_bug.cgi?id=6657

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug libc/6657] strptime era support broken

[pasky at suse dot cz]

------- Additional Comments From pasky at suse dot cz  2008-06-26 01:20 -------
Created an attachment (id=2799)
 --> (http://sourceware.org/bugzilla/attachment.cgi?id=2799&action=view)
tst-strptime.c patch to test for this issue

I'm sorry, I thought the issue is obvious from the code and my comment.

With your latest tst-strptime update, the issue does not demonstrate since it
occurs only because of the recursive %EY handling - this patch converts
tst-strptime to use that. If you still want me to, I can produce a standalone
testcase as well.

-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=6657

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug libc/6657] strptime era support broken

[drepper at redhat dot com]

------- Additional Comments From drepper at redhat dot com  2008-06-27 17:23 -------
The patch is correct.  But don't remove tests, add to the list.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED


http://sourceware.org/bugzilla/show_bug.cgi?id=6657

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.