public inbox for glibc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug libc/9901] New: Testsuite assumes SHELL is set and fails if not
@ 2009-02-25 16:57 lool+redhat at via dot ecp dot fr
2009-03-14 20:17 ` [Bug libc/9901] " drepper at redhat dot com
0 siblings, 1 reply; 2+ messages in thread
From: lool+redhat at via dot ecp dot fr @ 2009-02-25 16:57 UTC (permalink / raw)
To: glibc-bugs
Hi,
env -i make check fails with:
Testing ASCIItst-table.sh:38: command not found: tst-table-charmap.sh
while make check works.
This is due to the assumption SHELL is set:
<original env>: SHELL unset
$(MAKE) check: SHELL defined by make
$(SHELL) tst-tables.sh: SHELL is a regular var, not env
$(SHELL) tst-table.sh: SHELL unset (new shell)
$(SHELL) tst-table-charmap.sh: fails
This patch against CVS fixes it:
Index: iconvdata/tst-tables.sh
===================================================================
RCS file: /cvs/glibc/libc/iconvdata/tst-tables.sh,v
retrieving revision 1.34
diff -u -r1.34 tst-tables.sh
--- iconvdata/tst-tables.sh 12 Dec 2007 07:58:54 -0000 1.34
+++ iconvdata/tst-tables.sh 25 Feb 2009 16:57:03 -0000
@@ -25,6 +25,9 @@
common_objpfx=$1
objpfx=$2
+if test "$SHELL" = ""; then SHELL=/bin/sh; fi
+export SHELL
+
status=0
cat <<EOF |
BTW, This is with /bin/sh == bash, but my shell in passwd (getent passwd `id
-u`) is set to zsh which results in bash -c 'echo $SHELL' => /bin/zsh which
might be one reason it fails.
Bye
--
Summary: Testsuite assumes SHELL is set and fails if not
Product: glibc
Version: unspecified
Status: NEW
Severity: normal
Priority: P2
Component: libc
AssignedTo: drepper at redhat dot com
ReportedBy: lool+redhat at via dot ecp dot fr
CC: glibc-bugs at sources dot redhat dot com
GCC build triplet: x86_64-linux-gnu
GCC host triplet: x86_64-linux-gnu
GCC target triplet: x86_64-linux-gnu
http://sourceware.org/bugzilla/show_bug.cgi?id=9901
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
^ permalink raw reply [flat|nested] 2+ messages in thread
* [Bug libc/9901] Testsuite assumes SHELL is set and fails if not
2009-02-25 16:57 [Bug libc/9901] New: Testsuite assumes SHELL is set and fails if not lool+redhat at via dot ecp dot fr
@ 2009-03-14 20:17 ` drepper at redhat dot com
0 siblings, 0 replies; 2+ messages in thread
From: drepper at redhat dot com @ 2009-03-14 20:17 UTC (permalink / raw)
To: glibc-bugs
------- Additional Comments From drepper at redhat dot com 2009-03-14 20:17 -------
There are countless assumptions that are made while running the test suite. I
don't start changing the test suite so that people with strange/wrong
environments can run it. Fix up your environment.
--
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |WONTFIX
http://sourceware.org/bugzilla/show_bug.cgi?id=9901
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-03-14 20:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-02-25 16:57 [Bug libc/9901] New: Testsuite assumes SHELL is set and fails if not lool+redhat at via dot ecp dot fr
2009-03-14 20:17 ` [Bug libc/9901] " drepper at redhat dot com
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).