From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <glibc-bugs-return-9322-listarch-glibc-bugs=sources.redhat.com@sourceware.org>
Received: (qmail 31701 invoked by alias); 25 Feb 2009 16:57:51 -0000
Received: (qmail 31648 invoked by uid 48); 25 Feb 2009 16:57:34 -0000
Date: Wed, 25 Feb 2009 16:57:00 -0000
From: "lool+redhat at via dot ecp dot fr" <sourceware-bugzilla@sourceware.org>
To: glibc-bugs@sources.redhat.com
Message-ID: <20090225165733.9901.lool+redhat@via.ecp.fr>
Reply-To: sourceware-bugzilla@sourceware.org
Subject: [Bug libc/9901] New: Testsuite assumes SHELL is set and fails if not
X-Bugzilla-Reason: CC
Mailing-List: contact glibc-bugs-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <glibc-bugs.sourceware.org>
List-Subscribe: <mailto:glibc-bugs-subscribe@sourceware.org>
List-Post: <mailto:glibc-bugs@sourceware.org>
List-Help: <mailto:glibc-bugs-help@sourceware.org>, <http://sourceware.org/lists.html#faqs>
Sender: glibc-bugs-owner@sourceware.org
X-SW-Source: 2009-02/txt/msg00103.txt.bz2

Hi,

env -i make check fails with:
Testing ASCIItst-table.sh:38: command not found: tst-table-charmap.sh

while make check works.

This is due to the assumption SHELL is set:
    <original env>: SHELL unset
        $(MAKE) check: SHELL defined by make
            $(SHELL) tst-tables.sh: SHELL is a regular var, not env
                $(SHELL) tst-table.sh: SHELL unset (new shell)
                    $(SHELL) tst-table-charmap.sh: fails

This patch against CVS fixes it:
Index: iconvdata/tst-tables.sh
===================================================================
RCS file: /cvs/glibc/libc/iconvdata/tst-tables.sh,v
retrieving revision 1.34
diff -u -r1.34 tst-tables.sh
--- iconvdata/tst-tables.sh     12 Dec 2007 07:58:54 -0000      1.34
+++ iconvdata/tst-tables.sh     25 Feb 2009 16:57:03 -0000
@@ -25,6 +25,9 @@
 common_objpfx=$1
 objpfx=$2
 
+if test "$SHELL" = ""; then SHELL=/bin/sh; fi
+export SHELL
+
 status=0
 
 cat <<EOF |


BTW, This is with /bin/sh == bash, but my shell in passwd (getent passwd `id
-u`) is set to zsh which results in bash -c 'echo $SHELL' => /bin/zsh which
might be one reason it fails.

Bye

-- 
           Summary: Testsuite assumes SHELL is set and fails if not
           Product: glibc
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: libc
        AssignedTo: drepper at redhat dot com
        ReportedBy: lool+redhat at via dot ecp dot fr
                CC: glibc-bugs at sources dot redhat dot com
 GCC build triplet: x86_64-linux-gnu
  GCC host triplet: x86_64-linux-gnu
GCC target triplet: x86_64-linux-gnu


http://sourceware.org/bugzilla/show_bug.cgi?id=9901

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.