[Bug libc/9901] New: Testsuite assumes SHELL is set and fails if not

[Bug libc/9901] New: Testsuite assumes SHELL is set and fails if not

[lool+redhat at via dot ecp dot fr]

Hi,

env -i make check fails with:
Testing ASCIItst-table.sh:38: command not found: tst-table-charmap.sh

while make check works.

This is due to the assumption SHELL is set:
    <original env>: SHELL unset
        $(MAKE) check: SHELL defined by make
            $(SHELL) tst-tables.sh: SHELL is a regular var, not env
                $(SHELL) tst-table.sh: SHELL unset (new shell)
                    $(SHELL) tst-table-charmap.sh: fails

This patch against CVS fixes it:
Index: iconvdata/tst-tables.sh
===================================================================
RCS file: /cvs/glibc/libc/iconvdata/tst-tables.sh,v
retrieving revision 1.34
diff -u -r1.34 tst-tables.sh
--- iconvdata/tst-tables.sh     12 Dec 2007 07:58:54 -0000      1.34
+++ iconvdata/tst-tables.sh     25 Feb 2009 16:57:03 -0000
@@ -25,6 +25,9 @@
 common_objpfx=$1
 objpfx=$2
 
+if test "$SHELL" = ""; then SHELL=/bin/sh; fi
+export SHELL
+
 status=0
 
 cat <<EOF |


BTW, This is with /bin/sh == bash, but my shell in passwd (getent passwd `id
-u`) is set to zsh which results in bash -c 'echo $SHELL' => /bin/zsh which
might be one reason it fails.

Bye

-- 
           Summary: Testsuite assumes SHELL is set and fails if not
           Product: glibc
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: libc
        AssignedTo: drepper at redhat dot com
        ReportedBy: lool+redhat at via dot ecp dot fr
                CC: glibc-bugs at sources dot redhat dot com
 GCC build triplet: x86_64-linux-gnu
  GCC host triplet: x86_64-linux-gnu
GCC target triplet: x86_64-linux-gnu


http://sourceware.org/bugzilla/show_bug.cgi?id=9901

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug libc/9901] Testsuite assumes SHELL is set and fails if not

[drepper at redhat dot com]

------- Additional Comments From drepper at redhat dot com  2009-03-14 20:17 -------
There are countless assumptions that are made while running the test suite.  I
don't start changing the test suite so that people with strange/wrong
environments can run it.  Fix up your environment.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |WONTFIX


http://sourceware.org/bugzilla/show_bug.cgi?id=9901

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug libc/9901] Testsuite assumes SHELL is set and fails if not

[gabravier at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=9901

Gabriel Ravier <gabravier at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gabravier at gmail dot com

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug libc/9901] Testsuite assumes SHELL is set and fails if not

[fweimer at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=9901

Florian Weimer <fweimer at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |security-

-- 
You are receiving this mail because:
You are on the CC list for the bug.