[Bug nis/10432] New: _nss_nis_setnetgrent assertion failure

[Bug nis/10432] New: _nss_nis_setnetgrent assertion failure

[leonardo at ngdn dot org]

With a specific NIS + netgroup configuration, I can reproduce the following
problem consistently:

# ksh -c "ls ~leonardo"
ksh: nss_nis/nis-netgrp.c:74: _nss_nis_setnetgrent: Assertion
`malloc_usable_size (netgrp->data) >= len + 1' failed.
Aborted

Further debugging proved that the problem only happens when netgrp->data is
allocated by libast's malloc() instead of the regular glibc's malloc().

It seems that libast's version doesn't fill some fields in the malloc chunk,
more specifically, this is the macro -- called from malloc_usable_size -- that
fails (from malloc/malloc.c):

/* extract p's inuse bit */
#define inuse(p)\
 ((((mchunkptr)(((char*)(p))+((p)->size & ~SIZE_BITS)))->size) & PREV_INUSE)

If I understand correctly, the memory chunk is not marked as "in use".

As this is the only use of malloc_usable_size() in current glibc (outside
malloc.c), and the assert seems pointless, I'd like to suggest its removal.

I'm marking this against version 2.4 but I believe it's reproducible with latest
2.10/11 too.

-- 
           Summary: _nss_nis_setnetgrent assertion failure
           Product: glibc
           Version: 2.4
            Status: NEW
          Severity: normal
          Priority: P2
         Component: nis
        AssignedTo: kukuk at suse dot de
        ReportedBy: leonardo at ngdn dot org
                CC: glibc-bugs at sources dot redhat dot com


http://sourceware.org/bugzilla/show_bug.cgi?id=10432

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug nis/10432] _nss_nis_setnetgrent assertion failure

[leonardo at ngdn dot org]

------- Additional Comments From leonardo at ngdn dot org  2009-07-22 19:38 -------
Created an attachment (id=4076)
 --> (http://sourceware.org/bugzilla/attachment.cgi?id=4076&action=view)
suggested patch


-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=10432

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug nis/10432] _nss_nis_setnetgrent assertion failure

[pasky at suse dot cz]

------- Additional Comments From pasky at suse dot cz  2009-07-23 08:53 -------
Note that we also had crashes in Firefox reported at the same assert().

-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=10432

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug nis/10432] _nss_nis_setnetgrent assertion failure

[drepper at redhat dot com]

------- Additional Comments From drepper at redhat dot com  2009-10-30 05:44 -------
This is a bug in the other malloc implementations.  Get them to fix it.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |WONTFIX


http://sourceware.org/bugzilla/show_bug.cgi?id=10432

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug nis/10432] _nss_nis_setnetgrent assertion failure

[fweimer at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=10432

Florian Weimer <fweimer at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |security-

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug nis/10432] _nss_nis_setnetgrent assertion failure

[fweimer at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=10432

Florian Weimer <fweimer at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
                 CC|                            |fweimer at redhat dot com
         Resolution|WONTFIX                     |---

--- Comment #4 from Florian Weimer <fweimer at redhat dot com> ---
(In reply to Leonardo Chiquitto from comment #0)
> As this is the only use of malloc_usable_size() in current glibc (outside
> malloc.c), and the assert seems pointless, I'd like to suggest its removal.

This is a real problem, I think.  Overriding malloc does not require that you
override all of glibc's helper interfaces.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug nis/10432] _nss_nis_setnetgrent assertion failure

[fweimer at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=10432

Florian Weimer <fweimer at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |ASSIGNED

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug nis/10432] _nss_nis_setnetgrent assertion failure

[fweimer at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=10432

Florian Weimer <fweimer at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|kukuk at suse dot de               |fweimer at redhat dot com

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug nis/10432] _nss_nis_setnetgrent assertion failure

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=10432

--- Comment #5 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, master has been updated
       via  3670da6bfb1ffd17d9bdce2d31d79656be0991b5 (commit)
      from  f586e1328681b400078c995a0bb6ad301ef73549 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=3670da6bfb1ffd17d9bdce2d31d79656be0991b5

commit 3670da6bfb1ffd17d9bdce2d31d79656be0991b5
Author: Florian Weimer <fweimer@redhat.com>
Date:   Tue Oct 6 14:03:35 2015 +0200

    nss_nis: Do not call malloc_usable_size [BZ #10432]

    This is a namespace violation, and interposed malloc implementations
    are not required to interpose malloc_usable_size.

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog                |    6 ++++++
 NEWS                     |   20 ++++++++++----------
 nis/nss_nis/nis-netgrp.c |    1 -
 3 files changed, 16 insertions(+), 11 deletions(-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug nis/10432] _nss_nis_setnetgrent assertion failure

[fweimer at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=10432

Florian Weimer <fweimer at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #6 from Florian Weimer <fweimer at redhat dot com> ---
Fixed in glibc 2.23.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug nis/10432] _nss_nis_setnetgrent assertion failure

[jsm28 at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=10432

Joseph Myers <jsm28 at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |2.23

-- 
You are receiving this mail because:
You are on the CC list for the bug.