public inbox for glibc-bugs@sourceware.org help / color / mirror / Atom feed
From: "roland dot lezuo at chello dot at" <sourceware-bugzilla@sourceware.org> To: glibc-bugs@sources.redhat.com Subject: [Bug nptl/10815] New: [timer_create / SIGEV_THREAD] signalmask of timer_sigev_thread dangerous Date: Tue, 20 Oct 2009 10:11:00 -0000 [thread overview] Message-ID: <20091020101143.10815.roland.lezuo@chello.at> (raw) When a POSIX timer is created with timer_create and sigev_notify = SIGEV_THREAD glibc uses internal helper threads (timer_sigev_thread) to invoke the callback function. This helper threads unblocks all signals. <snip> /* Helper thread to call the user-provided function. */ static void * timer_sigev_thread (void *arg) { /* The parent thread has all signals blocked. This is a bit surprising for user code, although valid. We unblock all signals. */ sigset_t ss; sigemptyset (&ss); INTERNAL_SYSCALL_DECL (err); INTERNAL_SYSCALL (rt_sigprocmask, err, 4, SIG_SETMASK, &ss, NULL, _NSIG / 8); struct thread_start_data *td = (struct thread_start_data *) arg; <snap> According to the POSIX standard the signalmask of the thread executing the timer callback is implementation defined. The above comments indicates that the signal mask is cleared to not suprise user code. I have an application which uses multiple rt-signals. One of them is blocked by all threads and received using sigwaitinfo. The behaviour of timer_sigev_thread opens a race condition where the rt-signal is delivered and because there is no signal handler the application crashes. It is unfeasible to add a signal handler and propagate the event back to the signal handling code. I did not actually try on FreeBSD, but it seems they do not clear the signalmask. I think the correct way is to assume worst and have the signalmask blocking all signals. User code must be prepared to be executed with any signalmask, and by doing so glibc does not crash user applications depending on blocked signals and sigwaitinfo. -- Summary: [timer_create / SIGEV_THREAD] signalmask of timer_sigev_thread dangerous Product: glibc Version: 2.9 Status: NEW Severity: normal Priority: P2 Component: nptl AssignedTo: drepper at redhat dot com ReportedBy: roland dot lezuo at chello dot at CC: glibc-bugs at sources dot redhat dot com http://sourceware.org/bugzilla/show_bug.cgi?id=10815 ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.
next reply other threads:[~2009-10-20 10:11 UTC|newest] Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top 2009-10-20 10:11 roland dot lezuo at chello dot at [this message] 2009-10-20 11:31 ` [Bug nptl/10815] " drepper at redhat dot com
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20091020101143.10815.roland.lezuo@chello.at \ --to=sourceware-bugzilla@sourceware.org \ --cc=glibc-bugs@sources.redhat.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).